Why should m.request
and m.jsonp
be split?
#2734
dead-claudia
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Description
Currently,
m.request
andm.jsonp
are split. This was introduced in v1 per #1068I'm proposing for v3, let's move that back to
m.request
via the specialmethod: "JSONP"
(case-insensitive). We'd just ignorecallbackKey
andcallbackName
for non-JSONP requests, and user-visible handling is otherwise identical.Why
Leo's justification doesn't really hold up from a usability perspective. It really feels like it's leaking an implementation detail.
Plus, with modern CORS, JSONP has mostly just disappeared now, so we might be able to get away with just dropping it. It's been literally years since I've last needed to make a script request, and CORS is fully supported in IE10+. If we really wanted to support IE8-9, we could fall back to
XDomainRequest
on network failure for partial support, at the cost of moderately increased latency for those two browsers specifically. (It supports about 80% of XHR's API.)Possible Implementation & Open Questions
The implementation is self-explanatory. The main question of this bug is really this: do we want to keep them separate, combine them, or drop
m.jsonp
's functionality altogether?Is this something you're interested in working on?
Yes
Beta Was this translation helpful? Give feedback.
All reactions