Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomment and fix URL tests #91

Open
bannanc opened this issue Jul 14, 2019 · 0 comments
Open

Uncomment and fix URL tests #91

bannanc opened this issue Jul 14, 2019 · 0 comments
Labels
long term Caitlin did not have time to address

Comments

@bannanc
Copy link
Member

bannanc commented Jul 14, 2019

I wrote tests for urls in the documentation, following the methods used by openforcefield. Unfortunately, a couple of the urls that work when I click on them from READMEs were failing in these tests. I decided it wasn't worth my time to fight with since they are working links.

I'm not convinced we want our tests to fail every time someone else's server goes down so I don't know if having these tests are worth it in the first place.

@bannanc bannanc added the long term Caitlin did not have time to address label Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
long term Caitlin did not have time to address
Projects
None yet
Development

No branches or pull requests

1 participant