Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wish: allow model_profile to specify only some variable_splits (python) #470

Open
mayer79 opened this issue Oct 16, 2021 · 3 comments
Open
Labels
feature 💡 New feature or enhancement request Python 🐍 Related to Python

Comments

@mayer79
Copy link

mayer79 commented Oct 16, 2021

I am using dalex to plot multiple partial dependence plots in Python. It is a very useful package!

For some numeric features (especially those with outliers), I would like to specify the evaluation grid using option variable_splits in model_profile. However, if I do this, I need to specify a grid for all other features as well. Ideally, the function would use the keys in variable_splits only to overwrite the default. For those features without specified variable_splits key, it would resort to the default.

In the following case: the left-most feature should stop at a maximum of 10. The range for the other feature is fine though:

image

@hbaniecki hbaniecki added feature 💡 New feature or enhancement request Python 🐍 Related to Python labels Oct 17, 2021
@hbaniecki
Copy link
Member

Agreed, but it will change the default behaviour so it probably should be added in v1.5.0.

@mayer79 mayer79 closed this as completed Oct 17, 2021
@mayer79 mayer79 reopened this Oct 17, 2021
@mayer79
Copy link
Author

mayer79 commented Oct 17, 2021

Oops, wrong button ;-). Sounds reasonable! My suggestion only makes a difference if a variable list is passed as well. If there is no such list, it makes sense to only plot variables appearing in the keys.

@hbaniecki
Copy link
Member

Actually, I am not sure if it makes sense for the keys of variable_splits to override variables=None (like it is now). This behaviour was probably copied from R. I will investigate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 💡 New feature or enhancement request Python 🐍 Related to Python
Projects
None yet
Development

No branches or pull requests

2 participants