Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roc_pivot - not affecting predict function #22

Open
jakwisn opened this issue Sep 14, 2020 · 1 comment
Open

roc_pivot - not affecting predict function #22

jakwisn opened this issue Sep 14, 2020 · 1 comment
Assignees
@jakwisn
Labels
enhancement New feature or request

Comments

@jakwisn
Copy link
Member

jakwisn commented Sep 14, 2020

Post-processing function roc_pivot does affect only $y_hat of explainer and not the predict function. When dealing with new data it may be misleading. Therefore roc_pivot should also change predict function

Thanks @piotrpiatyszek for bringing it up
@jakwisn jakwisn added the enhancement New feature or request label Sep 14, 2020
@jakwisn jakwisn self-assigned this Sep 14, 2020
jakwisn added a commit that referenced this issue Sep 21, 2020
@jakwisn
docs solve #22
bf44916
@jakwisn
Copy link
Member Author

jakwisn commented Sep 21, 2020

This is a good issue and it needs to be discussed in more depth as the changes for this to take effect are affecting DALEX. As for now, it will remain open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakwisn jakwisn

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jakwisn