-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
You can get an empty file if you're quick #52
Comments
I'm not sure you even need to be quick. If I follow @patrickkettner 's link https://modernizr.com/download?flexbox&q=flex, I get the expected code. However if I manually select flexbox, and hit build, I note the address bar is reading: https://modernizr.com/download?flexbox-setclasses&q=flex and I get
|
Quick is relative to the machine you are on, it appears
|
@joecritch any opinion on what should be done in these situations? |
@patrickkettner @ryanseddon An inline spinner on the (disabled) Build button sounds good to me. I think blocking the use of the lightbox at this point is a positive restriction. Do we have a stock spinner on this site yet? |
No, we dont
|
Modernizr/Modernizr#1681
If you have a fresh cache and you're reasonably fast you can beat the build tool and get just the default js without the test you selected.
@joecritch any suggestions on ux around this? I was thinking of having the build button show a loading spinner in it?
The text was updated successfully, but these errors were encountered: