[1.20.1] Mixin crash while initializing game when Cumulus or Constant Music is installed

[STARRIVEN]

Environment

• Minecraft: 1.20.1
• Music Moods: 0.4.2
• Mod Loader: Forge 47.3.12 (running Music Moods via Sinytra Connector)
• Java: 17.0.13

To reproduce

1. Create an instance with both Music Moods and Cumulus (or instead Constant Music)
2. Launch the game
3. Crash, see logs

Crash logs

Latest log (constant music): https://mclo.gs/iZr9Uj0
Crash report (constant music): https://mclo.gs/6IUp9UE

Latest log (cumulus): https://mclo.gs/mgQXW6U
Crash report (cumulus): https://mclo.gs/EZytSAO

Anything else?

Originally found when trying to add Music Moods to a modpack with Aether and Constant Music installed, at first thought it was a crash between just Cumulus and Music Moods but found that it also happens with Constant Music when Aether was removed. In an instance with just the conflicting mods, launching the game without Music Moods or Aether/Constant Music fixes the crash. I use the Modrinth launcher, so I don't know if disabling Cumulus independently fixes it, as its a embedded dependency for Aether and doesn't appear in my mods folder or list.

I don't know which mod specifically is the root cause of the crash, but I have been able to run both Aether and Constant music together without any issues. for now, I'll report it here first.

[Ampflower]

Constant Music is a won't fix; we implement the same exact feature.

[Ampflower]

Cumulus seems to have hit an unlucky inject point in the MusicManager class and collided with Music Moods. I'm unsure what'd be the best course of action without studying how it injects or what the other brittle points are.

[STARRIVEN]

Sorry for the late reply, should I also make a report on the Cumulus repo to see if there could be a solution?

[Ampflower]

Isn't a bad idea I'd say; tho I'm unsure if they'll want to touch a Fabric mod running via Sinytra, since it does make it harder to debug than just straight Forge mods.

[Ampflower]

Cumulus exists on Fabric; will try to do some local debugging here then.

[Ampflower]

Okay so: Cumulus and Aether fails to load on Fabric for unknown reasons (Forge API nonsense seemingly?)

But none the less; the problem is simple.

https://github.com/The-Aether-Team/Cumulus/blob/c6b1a7d7d3a3eb940e5b34a50b42409370a7a891/src/main/java/com/aetherteam/cumulus/mixin/mixins/client/MusicManagerMixin.java#L19-L25

Cumulus injects into the music manager expecting the tick function to never change.

The solution meanwhile, is not; the overwrite would have to be rewritten to allow for original injects to exist.