Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weather: Pick up current configuration and add standard command line options for wire and station ID #227

Open
AESilky opened this issue Jan 13, 2021 · 0 comments
Open

Weather: Pick up current configuration and add standard command line options for wire and station ID #227

AESilky opened this issue Jan 13, 2021 · 0 comments
Labels
Common Config Common configuration (port, speed, type, etc.) related enhancement New feature or request

Comments

@AESilky
Copy link
Collaborator

AESilky commented Jan 13, 2021

Currently, the wire and station ID are hardcoded. There are configuration values for these that could (should) be picked up. In addition, there are 'standard' command line options to override the configured values if desired.

Use the command line processing to read the configured values and allow overriding them and remove the hardcoded values.
@AESilky AESilky added enhancement New feature or request Common Config Common configuration (port, speed, type, etc.) related labels Jan 13, 2021
pwdirks added a commit that referenced this issue Jan 25, 2021
@pwdirks
Fix #227: change Weather.py to use standard command line arguments
b71ae76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Common Config Common configuration (port, speed, type, etc.) related enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AESilky