Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] 프론트팀 내부 코드리뷰 피드백 후 리팩토링 #18

Closed
1 of 3 tasks
osohyun0224 opened this issue Aug 24, 2023 · 1 comment
Closed
1 of 3 tasks

[Fix] 프론트팀 내부 코드리뷰 피드백 후 리팩토링 #18

osohyun0224 opened this issue Aug 24, 2023 · 1 comment
Assignees
@osohyun0224
Labels
💻 frontend 프론트엔드 🛠️ refactoring 리팩토링

Comments

@osohyun0224
Copy link
Member

osohyun0224 commented Aug 24, 2023 •
edited
Loading

Description

pull request를 보며 팀 내부 코드리뷰 후 수정사항에 관한 피드백을 통해 리팩토링을 진행한다.

In Progress

작업사항들을 작성해주세요.

  • 백엔드 api 명세 확인 후 더미데이터 수정
  • css 컴포넌트 간 위치 설정으로 코드 변경
  • 강의 별 시간을 dayjs로 구현
@osohyun0224 osohyun0224 added 💻 frontend 프론트엔드 🛠️ refactoring 리팩토링 labels Aug 24, 2023
@osohyun0224 osohyun0224 self-assigned this Aug 24, 2023
@osohyun0224 osohyun0224 moved this to In Progress in Team Sprint Aug 24, 2023
This was referenced Aug 28, 2023
Merged
Merged
@PortalCube
Copy link
Contributor

PortalCube commented Sep 2, 2023 •
edited
Loading

#40 으로 병합합니다.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Sprint Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@osohyun0224 osohyun0224

Labels
💻 frontend 프론트엔드 🛠️ refactoring 리팩토링
Projects
Team Sprint
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PortalCube @osohyun0224