-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting for tone mapping #5229
Comments
This may be the old cell shading edger thing. Depending on perspective or what not a leading edge of blocks and things would get a somewhat thick black border for artistic style. I think it is similar to how it works in the game Borderlands? Come to think of it I haven't seen that for years - yet I have no memory of it explicitly being dropped or talked about in the past. Now I suddenly kinda miss it. It felt very distinct - but also oh so long ago. This may be hard to explain without a screenshot, here's one I grabbed off Google from Borderlands that sort of shows it, largely on the top of the terrain to the right: |
This is an outline thing, sorry I made a mistake, it's tone mapping, not toon mapping. Tone mapping is a thing that remap HDR color to LDR space. see this video for futher information https://www.bilibili.com/video/BV1gb4y1C7aM |
Oooh... Tone mapping not Toon mapping - yeah okay 😁 ToneMapping - maybe that's one of a couple effects that were introduced long ago to make block textures better ? Like one was meant to make cracks look 3D while another made metallic spots "shiny" - both of them depended on outright definitions on a block to enable the feature. |
nope. cracks 3d and metallic shinny are PBR shader. |
There is ToonMapping in the code, and close finished, but i didn't find any options to enable or disable it
The text was updated successfully, but these errors were encountered: