From 25abc8dc4a11b525366dd5eac773091d78b12c8f Mon Sep 17 00:00:00 2001
From: Sebastian <13592751+MrSebastian@users.noreply.github.com>
Date: Sun, 17 Mar 2024 01:43:10 +0100
Subject: [PATCH 1/4] add delete function to frontend client and service

---
 .../features/person/services/PersonService.ts |  4 ++++
 .../services/api/PersonClientInterface.ts     |  3 +++
 .../localstorage/PersonClientLocalStorage.ts  | 22 +++++++++++++++----
 .../api/impl/rest/PersonRestClient.ts         |  8 +++++++
 4 files changed, 33 insertions(+), 4 deletions(-)

diff --git a/frontend/frontend/src/features/person/services/PersonService.ts b/frontend/frontend/src/features/person/services/PersonService.ts
index 8306ccf7..28a201bc 100644
--- a/frontend/frontend/src/features/person/services/PersonService.ts
+++ b/frontend/frontend/src/features/person/services/PersonService.ts
@@ -27,4 +27,8 @@ export default class PersonService {
                 )
             );
     }
+
+    deletePerson(personId: string): Promise<void> {
+        return this.personClient.deletePerson(personId);
+    }
 }
diff --git a/frontend/frontend/src/features/person/services/api/PersonClientInterface.ts b/frontend/frontend/src/features/person/services/api/PersonClientInterface.ts
index 8701280d..4c4d0c8e 100644
--- a/frontend/frontend/src/features/person/services/api/PersonClientInterface.ts
+++ b/frontend/frontend/src/features/person/services/api/PersonClientInterface.ts
@@ -3,5 +3,8 @@ import type PersonDTO from "@/features/person/services/api/model/PersonDTO";
 
 export interface PersonClientInterface {
     getPersonen(): Promise<PersonDTO[]>;
+
     createPerson(person: PersonCreateDTO): Promise<PersonDTO>;
+
+    deletePerson(id: string): Promise<void>;
 }
diff --git a/frontend/frontend/src/features/person/services/api/impl/localstorage/PersonClientLocalStorage.ts b/frontend/frontend/src/features/person/services/api/impl/localstorage/PersonClientLocalStorage.ts
index db00ca78..41133f00 100644
--- a/frontend/frontend/src/features/person/services/api/impl/localstorage/PersonClientLocalStorage.ts
+++ b/frontend/frontend/src/features/person/services/api/impl/localstorage/PersonClientLocalStorage.ts
@@ -27,6 +27,19 @@ export default class PersonClientLocalStorage implements PersonClientInterface {
         );
     }
 
+    deletePerson(id: string): Promise<void> {
+        const personsOfLocalStorage = this.getOrCreatePersonsOfLocalStorage();
+        const indexOfPersonToDelete = personsOfLocalStorage.findIndex(
+            (person) => person.id === id
+        );
+        if (indexOfPersonToDelete !== -1) {
+            personsOfLocalStorage.splice(indexOfPersonToDelete);
+            this.saveAllPersons(personsOfLocalStorage);
+        }
+
+        return Promise.resolve();
+    }
+
     private getOrCreatePersonsOfLocalStorage(): Array<Person> {
         let localStoragePersonsAsString = localStorage.getItem(
             this.KEY_PERSON_ARRAY
@@ -46,9 +59,10 @@ export default class PersonClientLocalStorage implements PersonClientInterface {
     private savePerson(person: Person): void {
         const localPersons = this.getOrCreatePersonsOfLocalStorage();
         localPersons.push(person);
-        localStorage.setItem(
-            this.KEY_PERSON_ARRAY,
-            JSON.stringify(localPersons)
-        );
+        this.saveAllPersons(localPersons);
+    }
+
+    private saveAllPersons(persons: Person[]): void {
+        localStorage.setItem(this.KEY_PERSON_ARRAY, JSON.stringify(persons));
     }
 }
diff --git a/frontend/frontend/src/features/person/services/api/impl/rest/PersonRestClient.ts b/frontend/frontend/src/features/person/services/api/impl/rest/PersonRestClient.ts
index 77783f15..75a6bb0c 100644
--- a/frontend/frontend/src/features/person/services/api/impl/rest/PersonRestClient.ts
+++ b/frontend/frontend/src/features/person/services/api/impl/rest/PersonRestClient.ts
@@ -9,6 +9,7 @@ export default class PersonRestClient implements PersonClientInterface {
     private readonly PATH_PERSON = "/person";
 
     private readonly fetchUtils = new FetchUtils();
+
     createPerson(person: PersonCreateDTO): Promise<PersonDTO> {
         return this.fetchUtils.doFetch<PersonDTO>(
             `${API_BACKEND_BASE}${this.PATH_PERSON}`,
@@ -22,4 +23,11 @@ export default class PersonRestClient implements PersonClientInterface {
             FetchUtils.getGETConfig()
         );
     }
+
+    deletePerson(id: string): Promise<void> {
+        return this.fetchUtils.doFetch<void>(
+            `${API_BACKEND_BASE}${this.PATH_PERSON}/${id}`,
+            FetchUtils.getDeletConfig()
+        );
+    }
 }

From 6b17504c7ea934fc3515b4ddf0de7febc9d26413 Mon Sep 17 00:00:00 2001
From: Sebastian <13592751+MrSebastian@users.noreply.github.com>
Date: Sun, 17 Mar 2024 01:43:28 +0100
Subject: [PATCH 2/4] add deletion function to components

---
 .../person/components/BasePersonList.vue         |  8 ++++++++
 .../person/components/BasePersonListItem.vue     | 15 +++++++++++++++
 frontend/frontend/src/views/PersonView.vue       | 16 ++++++++++++----
 3 files changed, 35 insertions(+), 4 deletions(-)

diff --git a/frontend/frontend/src/features/person/components/BasePersonList.vue b/frontend/frontend/src/features/person/components/BasePersonList.vue
index 3be3c791..fe97e3be 100644
--- a/frontend/frontend/src/features/person/components/BasePersonList.vue
+++ b/frontend/frontend/src/features/person/components/BasePersonList.vue
@@ -4,6 +4,7 @@
             v-for="(person, index) in props.persons"
             :key="index"
             :person="person"
+            @delete="handleDeleteRequest"
         />
     </v-list>
 </template>
@@ -18,6 +19,13 @@ interface IProps {
 }
 
 const props = defineProps<IProps>();
+const emit = defineEmits<{
+    (e: "delete", value: string): void;
+}>();
+
+function handleDeleteRequest(personIdToDelete: string) {
+    emit("delete", personIdToDelete);
+}
 </script>
 
 <style scoped></style>
diff --git a/frontend/frontend/src/features/person/components/BasePersonListItem.vue b/frontend/frontend/src/features/person/components/BasePersonListItem.vue
index 1c623391..914e7f41 100644
--- a/frontend/frontend/src/features/person/components/BasePersonListItem.vue
+++ b/frontend/frontend/src/features/person/components/BasePersonListItem.vue
@@ -4,6 +4,12 @@
         :subtitle="props.person.id"
     >
         {{ props.person.email }}
+
+        <template #append>
+            <div>
+                <base-delete-icon-button @click="handleDeleteClicked" />
+            </div>
+        </template>
     </v-list-item>
 </template>
 
@@ -12,15 +18,24 @@ import type PersonPersisted from "@/features/person/types/PersonPersisted";
 
 import { computed } from "vue";
 
+import BaseDeleteIconButton from "@/components/common/buttons/icon/BaseDeleteIconButton.vue";
+
 interface IProps {
     person: PersonPersisted;
 }
 
 const props = defineProps<IProps>();
+const emit = defineEmits<{
+    (e: "delete", value: string): void;
+}>();
 
 const fullname = computed(
     () => `${props.person.firstname ?? ""} ${props.person.lastname ?? ""}`
 );
+
+function handleDeleteClicked() {
+    emit("delete", props.person.id);
+}
 </script>
 
 <style scoped></style>
diff --git a/frontend/frontend/src/views/PersonView.vue b/frontend/frontend/src/views/PersonView.vue
index 0b5111a5..fb7fc9d8 100644
--- a/frontend/frontend/src/views/PersonView.vue
+++ b/frontend/frontend/src/views/PersonView.vue
@@ -1,8 +1,8 @@
 <template>
     <v-container>
         <v-row class="text-center">
-            <v-col cols="12"
-                ><base-person-add-button @click="handlePersonAddClicked" />
+            <v-col cols="12">
+                <base-person-add-button @click="handlePersonAddClicked" />
             </v-col>
         </v-row>
 
@@ -13,11 +13,15 @@
                         icon
                         variant="flat"
                         @click="handleReloadClicked"
-                        ><v-icon>mdi-reload</v-icon></v-btn
                     >
+                        <v-icon>mdi-reload</v-icon>
+                    </v-btn>
                 </div>
                 <div>
-                    <base-person-list :persons="persons" />
+                    <base-person-list
+                        :persons="persons"
+                        @delete="handlePersonDeleteRequest"
+                    />
                 </div>
             </v-col>
         </v-row>
@@ -50,6 +54,10 @@ function handlePersonAdded() {
     loadPersons();
 }
 
+function handlePersonDeleteRequest(personIdForDeletion: string): void {
+    personService.deletePerson(personIdForDeletion).then(() => loadPersons());
+}
+
 function handlePersonAddClicked() {
     showPersonCreateDialog();
 }

From bac8af7dfd2e5bfe92c4694f07f292130c85bdb1 Mon Sep 17 00:00:00 2001
From: Sebastian <13592751+MrSebastian@users.noreply.github.com>
Date: Sun, 17 Mar 2024 01:44:56 +0100
Subject: [PATCH 3/4] implement delete person in backend

---
 .../person/dataaccess/PersonDataAccessService.java     |  2 ++
 .../dataaccess/document/PersonDocumentService.java     |  5 +++++
 .../person/dataaccess/entity/PersonSQLService.java     |  5 +++++
 .../backend/person/rest/PersonController.java          |  9 +++++++++
 .../backend/person/service/PersonService.java          | 10 ++++++++++
 .../person/service/events/PersonDeleteEvent.java       |  7 +++++++
 6 files changed, 38 insertions(+)
 create mode 100644 backend/src/main/java/de/mrsebastian/todoappdemo/backend/person/service/events/PersonDeleteEvent.java

diff --git a/backend/src/main/java/de/mrsebastian/todoappdemo/backend/person/dataaccess/PersonDataAccessService.java b/backend/src/main/java/de/mrsebastian/todoappdemo/backend/person/dataaccess/PersonDataAccessService.java
index ae0d59f9..4c3c76c0 100644
--- a/backend/src/main/java/de/mrsebastian/todoappdemo/backend/person/dataaccess/PersonDataAccessService.java
+++ b/backend/src/main/java/de/mrsebastian/todoappdemo/backend/person/dataaccess/PersonDataAccessService.java
@@ -9,5 +9,7 @@ public interface PersonDataAccessService {
 
     PersonDao createPerson(PersonCreateDao personCreateDao);
 
+    void deletePerson(UUID id);
+
     boolean personExists(UUID id);
 }
diff --git a/backend/src/main/java/de/mrsebastian/todoappdemo/backend/person/dataaccess/document/PersonDocumentService.java b/backend/src/main/java/de/mrsebastian/todoappdemo/backend/person/dataaccess/document/PersonDocumentService.java
index 1236584e..33be7f02 100644
--- a/backend/src/main/java/de/mrsebastian/todoappdemo/backend/person/dataaccess/document/PersonDocumentService.java
+++ b/backend/src/main/java/de/mrsebastian/todoappdemo/backend/person/dataaccess/document/PersonDocumentService.java
@@ -32,6 +32,11 @@ public PersonDao createPerson(PersonCreateDao personCreateDao) {
         return personDaoMapper.toDao(repository.save(personToCreate));
     }
 
+    @Override
+    public void deletePerson(UUID id) {
+        repository.deleteById(id);
+    }
+
     @Override
     public boolean personExists(UUID id) {
         return repository.existsById(id);
diff --git a/backend/src/main/java/de/mrsebastian/todoappdemo/backend/person/dataaccess/entity/PersonSQLService.java b/backend/src/main/java/de/mrsebastian/todoappdemo/backend/person/dataaccess/entity/PersonSQLService.java
index 9e0fc4d1..eed7d7fb 100644
--- a/backend/src/main/java/de/mrsebastian/todoappdemo/backend/person/dataaccess/entity/PersonSQLService.java
+++ b/backend/src/main/java/de/mrsebastian/todoappdemo/backend/person/dataaccess/entity/PersonSQLService.java
@@ -29,6 +29,11 @@ public PersonDao createPerson(final PersonCreateDao personCreateDao) {
         return sqlDaoMapper.toDao(personRepository.save(entityToSave));
     }
 
+    @Override
+    public void deletePerson(UUID id) {
+        personRepository.deleteById(id);
+    }
+
     @Override
     public boolean personExists(UUID id) {
         return personRepository.existsById(id);
diff --git a/backend/src/main/java/de/mrsebastian/todoappdemo/backend/person/rest/PersonController.java b/backend/src/main/java/de/mrsebastian/todoappdemo/backend/person/rest/PersonController.java
index 23ab8411..b84d7224 100644
--- a/backend/src/main/java/de/mrsebastian/todoappdemo/backend/person/rest/PersonController.java
+++ b/backend/src/main/java/de/mrsebastian/todoappdemo/backend/person/rest/PersonController.java
@@ -2,9 +2,12 @@
 
 import de.mrsebastian.todoappdemo.backend.person.service.PersonService;
 import jakarta.validation.Valid;
+import java.util.UUID;
 import lombok.RequiredArgsConstructor;
 import org.springframework.http.HttpStatus;
+import org.springframework.web.bind.annotation.DeleteMapping;
 import org.springframework.web.bind.annotation.GetMapping;
+import org.springframework.web.bind.annotation.PathVariable;
 import org.springframework.web.bind.annotation.PostMapping;
 import org.springframework.web.bind.annotation.RequestBody;
 import org.springframework.web.bind.annotation.RequestMapping;
@@ -28,4 +31,10 @@ public Iterable<PersonDTO> getPersonen() {
     public PersonDTO createPerson(@Valid @RequestBody PersonCreateDTO personCreateDTO) {
         return personService.createPerson(personCreateDTO);
     }
+
+    @DeleteMapping("{id}")
+    @ResponseStatus(HttpStatus.NO_CONTENT)
+    public void deletePerson(@PathVariable("id") UUID personId) {
+        personService.deletePerson(personId);
+    }
 }
diff --git a/backend/src/main/java/de/mrsebastian/todoappdemo/backend/person/service/PersonService.java b/backend/src/main/java/de/mrsebastian/todoappdemo/backend/person/service/PersonService.java
index d1fd549d..9f0fb4d8 100644
--- a/backend/src/main/java/de/mrsebastian/todoappdemo/backend/person/service/PersonService.java
+++ b/backend/src/main/java/de/mrsebastian/todoappdemo/backend/person/service/PersonService.java
@@ -5,10 +5,12 @@
 import de.mrsebastian.todoappdemo.backend.person.dataaccess.entity.Person;
 import de.mrsebastian.todoappdemo.backend.person.rest.PersonCreateDTO;
 import de.mrsebastian.todoappdemo.backend.person.rest.PersonDTO;
+import de.mrsebastian.todoappdemo.backend.person.service.events.PersonDeleteEvent;
 import java.util.List;
 import java.util.UUID;
 import lombok.RequiredArgsConstructor;
 import lombok.val;
+import org.springframework.context.ApplicationEventPublisher;
 import org.springframework.stereotype.Service;
 
 @Service
@@ -19,6 +21,8 @@ public class PersonService {
 
     private final PersonDataAccessService personDAService;
 
+    private final ApplicationEventPublisher applicationEventPublisher;
+
     public List<PersonDTO> getPersonen() {
         return personDAService.getPersonen().stream().map(personMapper::toDto).toList();
     }
@@ -28,6 +32,12 @@ public PersonDTO createPerson(final PersonCreateDTO personCreateDTO) {
         return personMapper.toDto(personDAService.createPerson(personDaoForCreate));
     }
 
+    public void deletePerson(final UUID personId) {
+        existsOrThrow(personId);
+        personDAService.deletePerson(personId);
+        applicationEventPublisher.publishEvent(new PersonDeleteEvent(personId));
+    }
+
     public void existsOrThrow(final UUID personId) {
         if (!personDAService.personExists(personId)) {
             throw new NotFoundException(personId, Person.class);
diff --git a/backend/src/main/java/de/mrsebastian/todoappdemo/backend/person/service/events/PersonDeleteEvent.java b/backend/src/main/java/de/mrsebastian/todoappdemo/backend/person/service/events/PersonDeleteEvent.java
new file mode 100644
index 00000000..f57c6bc8
--- /dev/null
+++ b/backend/src/main/java/de/mrsebastian/todoappdemo/backend/person/service/events/PersonDeleteEvent.java
@@ -0,0 +1,7 @@
+package de.mrsebastian.todoappdemo.backend.person.service.events;
+
+import jakarta.validation.constraints.NotNull;
+import java.util.UUID;
+
+public record PersonDeleteEvent(@NotNull UUID personId) {
+}

From c4a635a24805f1ea50079ebe5c823ae88f004848 Mon Sep 17 00:00:00 2001
From: Sebastian <13592751+MrSebastian@users.noreply.github.com>
Date: Sun, 17 Mar 2024 01:46:01 +0100
Subject: [PATCH 4/4] delete person ref from task assignee

---
 .../backend/task/service/TaskService.java     |  5 +++++
 .../service/events/PersonEventsListener.java  | 19 +++++++++++++++++++
 2 files changed, 24 insertions(+)
 create mode 100644 backend/src/main/java/de/mrsebastian/todoappdemo/backend/task/service/events/PersonEventsListener.java

diff --git a/backend/src/main/java/de/mrsebastian/todoappdemo/backend/task/service/TaskService.java b/backend/src/main/java/de/mrsebastian/todoappdemo/backend/task/service/TaskService.java
index 446f8a15..e000b22d 100644
--- a/backend/src/main/java/de/mrsebastian/todoappdemo/backend/task/service/TaskService.java
+++ b/backend/src/main/java/de/mrsebastian/todoappdemo/backend/task/service/TaskService.java
@@ -72,6 +72,11 @@ public void updateTaskAssignee(final UUID taskId, @Nullable final TaskAssigneeDT
         }
     }
 
+    @PreAuthorize("hasAnyRole(T(de.mrsebastian.todoappdemo.backend.security.AuthoritiesEnum).TASK_ADMIN.name())")
+    public void removePersonFromTasks(final UUID personId) {
+        getTaskWithAssignee(personId).forEach(task -> taskDAService.removeAssignee(task.id()));
+    }
+
     private void checkIfExistsOrThrow(final UUID taskId) {
         if (!taskDAService.taskExsits(taskId)) {
             throw new NotFoundException(taskId, Task.class);
diff --git a/backend/src/main/java/de/mrsebastian/todoappdemo/backend/task/service/events/PersonEventsListener.java b/backend/src/main/java/de/mrsebastian/todoappdemo/backend/task/service/events/PersonEventsListener.java
new file mode 100644
index 00000000..c7737064
--- /dev/null
+++ b/backend/src/main/java/de/mrsebastian/todoappdemo/backend/task/service/events/PersonEventsListener.java
@@ -0,0 +1,19 @@
+package de.mrsebastian.todoappdemo.backend.task.service.events;
+
+import de.mrsebastian.todoappdemo.backend.person.service.events.PersonDeleteEvent;
+import de.mrsebastian.todoappdemo.backend.task.service.TaskService;
+import lombok.AllArgsConstructor;
+import org.springframework.context.event.EventListener;
+import org.springframework.stereotype.Component;
+
+@Component
+@AllArgsConstructor
+public class PersonEventsListener {
+
+    private final TaskService taskService;
+
+    @EventListener
+    public void handlePersonDeletedEvent(final PersonDeleteEvent personDeleteEvent) {
+        taskService.removePersonFromTasks(personDeleteEvent.personId());
+    }
+}