Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] GPG Signing Support #121

Open
OdinVex opened this issue Mar 30, 2022 · 9 comments · May be fixed by #405
Open

[Feature Request] GPG Signing Support #121

OdinVex opened this issue Mar 30, 2022 · 9 comments · May be fixed by #405
Labels
enhancement New feature or request

Comments

@OdinVex
Copy link
Contributor

OdinVex commented Mar 30, 2022

It'd be extremely helpful to have GPG-signing support, to verify uploads.

@exactly-one-kas exactly-one-kas added the enhancement New feature or request label Apr 3, 2022
@dima-altinity
Copy link

+1 from me

@MeerMusik
Copy link

Yes please. I am currently looking for an Alternative to SmartGit. Unfortunately, Gittyup is unusable for me without this Feature, as I need to sign all my commits. Gittyup ignores all the aliases like cm -s -S commit -s -S set in the gitconfig File.

Thank you in advance!

@OdinVex
Copy link
Contributor Author

OdinVex commented Dec 21, 2022

Yes please. I am currently looking for an Alternative to SmartGit. Unfortunately, Gittyup is unusable for me without this Feature, as I need to sign all my commits. Gittyup ignores all the aliases like cm -s -S commit -s -S set in the gitconfig File.

Thank you in advance!

The Flatpak version won't use your git config. You need to find 'your' git config in the Flatpak user files and edit it to autosign, or if you manually install it as per your distro you can edit your git config to autosign, and it will. Or you can edit the src to add signing. I require autosigning myself. I may be able to spare some time this week to look at and add support for it. It's a very useful feature (and in some cases, required).

@MeerMusik
Copy link

Thanks for the Tip but I am running Gittyup on Windows 10 22H2. Not a Flatpak, Docker or whatever variant.

@OdinVex
Copy link
Contributor Author

OdinVex commented Dec 22, 2022

Thanks for the Tip but I am running Gittyup on Windows 10 22H2. Not a Flatpak, Docker or whatever variant.

Find the actual git executable used by Gittyup and if it uses a 'local' git, then modify the config to add auto-signing. When I find time, I'll look at adding it in this week, you can then pull src and compile if needed before the next version release.

Edit: Temporarily, you can go into Tools-Options [General] and click Edit Config, put this in there:

[format]
	signOff = true

This is specifically for adding a signoff message. You can also template the message in that config too, just as you would for a git config.

If you want to temporarily (without UI automation) add gpg signing, you can add:

[commit]
	gpgSign = true
[push]
	gpgSign = true
[tag]
	gpgSign = true

@OdinVex
Copy link
Contributor Author

OdinVex commented Dec 22, 2022

Edit: I've made a Pull Request (#405) to add these features. I don't know if we'll need to put up some UI icons (locks or checkmarks?) to show 'verified' signed stuff, would be nice. I don't recall if Gittyup does that currently.

@OdinVex OdinVex linked a pull request Dec 22, 2022 that will close this issue
@OdinVex
Copy link
Contributor Author

OdinVex commented Dec 22, 2022

Edit: I forgot that last year I modified Gittyup to remove code that worked with commits to use my installation's git instead, to specifically support signoff and GPG because libgit2 does support git_commit_create_with_signature, but that is required to be implemented via the software. I implemented it using host git. It was a hackish work-around I forgot about. It works, but I don't think Gittyup wants to use local git installations...even though that would bring 'your installed version of git' support. Sorry I got everyone's hopes up on that. My solution isn't a publicly-shippable one.

@WrichikBasu
Copy link

@OdinVex Maybe you could throw some light on what changes you made to the source files that makes Gittyup use my installed version of Git, and thereby sign commits? Then interested users can actually build from source if they like.

@OdinVex
Copy link
Contributor Author

OdinVex commented Sep 6, 2023

@OdinVex Maybe you could throw some light on what changes you made to the source files that makes Gittyup use my installed version of Git, and thereby sign commits? Then interested users can actually build from source if they like.

I moved onto another project and no longer have the source. X_x; I was using Gittyup externally for Unreal Engine, but now I use the integrated plugin (versus the external plugin which came after my use of Gittyup).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants