Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameFinder.StoreHandlers.Steam.Services.AppManifestParser crashes with empty manifest #486

Closed
some1one opened this issue Oct 18, 2024 · 2 comments

Comments

@some1one
Copy link

Somehow i ended up with a steam game manifest that is empty so when the SteamHandler.FindAllGames is called, it crashes when it tries to parse that one. I'm not sure it is necessary to parse every steam manifest? The root call is

GameEnvironment.Typical
    .Builder<ISkyrimMod, ISkyrimModGetter>(GameRelease.SkyrimSE)
    .Build()

ValveKeyValue.dll!ValveKeyValue.Deserialization.KeyValues1.KV1TextReader.FinalizeCurrentObject(bool explicit) Line 168
(KV1TextReader.cs:168)
ValveKeyValue.dll!ValveKeyValue.Deserialization.KeyValues1.KV1TextReader.FinalizeDocument() Line 190 (KV1TextReader.cs:190)
ValveKeyValue.dll!ValveKeyValue.Deserialization.KeyValues1.KV1TextReader.ReadObject() Line 72 (KV1TextReader.cs:72)
ValveKeyValue.dll!ValveKeyValue.KVSerializer.Deserialize(System.IO.Stream stream, ValveKeyValue.KVSerializerOptions options) Line 41 (KVSerializer.cs:41)
GameFinder.StoreHandlers.Steam.dll!GameFinder.StoreHandlers.Steam.Services.AppManifestParser.ParseManifestFile(NexusMods.Paths.AbsolutePath manifestPath) Line 40 (AppManifestParser.cs:40)
GameFinder.StoreHandlers.Steam.dll!GameFinder.StoreHandlers.Steam.SteamHandler.FindAllGames() Line 91 (SteamHandler.cs:91)
System.Linq.dll!System.Collections.Generic.LargeArrayBuilder<OneOf.OneOf<GameFinder.StoreHandlers.Steam.SteamGame, GameFinder.Common.ErrorMessage>>.AddRange(System.Collections.Generic.IEnumerable<OneOf.OneOf<GameFinder.StoreHandlers.Steam.SteamGame, GameFinder.Common.ErrorMessage>> items) Line 112 (LargeArrayBuilder.SpeedOpt.cs:112)
System.Linq.dll!System.Collections.Generic.EnumerableHelpers.ToArray<OneOf.OneOf<GameFinder.StoreHandlers.Steam.SteamGame, GameFinder.Common.ErrorMessage>>(System.Collections.Generic.IEnumerable<OneOf.OneOf<GameFinder.StoreHandlers.Steam.SteamGame, GameFinder.Common.ErrorMessage>> source) Line 84 (EnumerableHelpers.Linq.cs:84)
System.Linq.dll!System.Linq.Enumerable.ToArray<OneOf.OneOf<GameFinder.StoreHandlers.Steam.SteamGame, GameFinder.Common.ErrorMessage>>(System.Collections.Generic.IEnumerable<OneOf.OneOf<GameFinder.StoreHandlers.Steam.SteamGame, GameFinder.Common.ErrorMessage>> source) Line 17 (ToCollection.cs:17)
GameFinder.Common.dll!GameFinder.Common.Extensions.SplitResults<GameFinder.StoreHandlers.Steam.SteamGame>(System.Collections.Generic.IEnumerable<OneOf.OneOf<GameFinder.StoreHandlers.Steam.SteamGame, GameFinder.Common.ErrorMessage>> results) Line 27 (Extensions.cs:27)
GameFinder.Common.dll!GameFinder.Common.AHandler<GameFinder.StoreHandlers.Steam.SteamGame, GameFinder.StoreHandlers.Steam.Models.ValueTypes.AppId>.FindAllGamesById(out GameFinder.Common.ErrorMessage[] errors) Line 78 (AHandler.cs:78)
GameFinder.Common.dll!GameFinder.Common.AHandler<GameFinder.StoreHandlers.Steam.SteamGame, GameFinder.StoreHandlers.Steam.Models.ValueTypes.AppId>.FindOneGameById(GameFinder.StoreHandlers.Steam.Models.ValueTypes.AppId id, out GameFinder.Common.ErrorMessage[] errors) Line 94 (AHandler.cs:94)
Mutagen.Bethesda.Core.dll!Mutagen.Bethesda.Installs.GameLocator.TryGetSteamGameFolder(Mutagen.Bethesda.Installs.SteamGameSource steamGameSource, out Noggog.DirectoryPath directoryPath) (Unknown Source:0)
Mutagen.Bethesda.Core.dll!Mutagen.Bethesda.Installs.GameLocator.TryGetGameDirectory(Mutagen.Bethesda.Installs.IGameSource gameSource, out Noggog.DirectoryPath path) (Unknown Source:0)
Mutagen.Bethesda.Core.dll!Mutagen.Bethesda.Installs.GameLocator.GetAllGameDirectories(Mutagen.Bethesda.GameRelease release) (Unknown Source:0)
System.Linq.dll!System.Collections.Generic.LargeArrayBuilder<Noggog.DirectoryPath>.AddRange(System.Collections.Generic.IEnumerable<Noggog.DirectoryPath> items) Line 112 (LargeArrayBuilder.SpeedOpt.cs:112)
System.Linq.dll!System.Collections.Generic.EnumerableHelpers.ToArray<Noggog.DirectoryPath>(System.Collections.Generic.IEnumerable<Noggog.DirectoryPath> source) Line 84 (EnumerableHelpers.Linq.cs:84)
System.Linq.dll!System.Linq.Enumerable.ToArray<Noggog.DirectoryPath>(System.Collections.Generic.IEnumerable<Noggog.DirectoryPath> source) Line 17 (ToCollection.cs:17)
Mutagen.Bethesda.Core.dll!Mutagen.Bethesda.Installs.DI.GameLocatorLookupCache.GetAllGameDirectories(Mutagen.Bethesda.GameRelease release) (Unknown Source:0)
Mutagen.Bethesda.Core.dll!Mutagen.Bethesda.Installs.DI.GameLocatorLookupCache.TryGetGameDirectory(Mutagen.Bethesda.GameRelease release, out Noggog.DirectoryPath path) (Unknown Source:0)

@Noggog
Copy link
Member

Noggog commented Oct 19, 2024

This is an issue for the lib that mutagen uses:
https://github.com/erri120/GameFinder

Mutagen itself doesn't do any direct steam interaction within its code

@Noggog Noggog closed this as completed Oct 19, 2024
@some1one
Copy link
Author

erri120/GameFinder#156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants