Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity matching more than it should #4

Open
penrods opened this issue Feb 20, 2018 · 2 comments
Open

Entity matching more than it should #4

penrods opened this issue Feb 20, 2018 · 2 comments

Comments

@penrods
Copy link
Contributor

penrods commented Feb 20, 2018

For an intent file like this:
(Start|Set) (a|) 5 minute timer (called|for) {name}.
The phrase:
"start a 5 minute timer called lasagna"
Return the entity "name" as "called lasagna".

However it does correctly parse:
"set a 5 minute timer called lasagna"
Returning the entity "name" as "lasagna".

@MatthewScholefield
Copy link
Collaborator

Can you check if this is still an issue? It should be fixed since perfect matches are now guaranteed.

@traverseda
Copy link

traverseda commented Jul 12, 2019

Having problems that look like this in https://github.com/traverseda/mycroft-skill-unitconversion

Are you saying there should be guaranteed perfect matches on entities?

I've also had it fail to return values that weren't optional. For example, how many miles is 4 shouldn't work, if I understand the intent parsing correctly.

I think what is 4 plus 4 definitely shouldn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants