Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compat by temporarily suspending shaders while another mod uses the vanilla ShaderManager #4

Open
Johni0702 opened this issue Feb 8, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@Johni0702
Copy link

Albedo might want to suspend its shaders while another mod tries to use the vanilla ShaderManager. E.g. BetterPortals uses the ShaderManager to render its portal framebuffers into the world: https://github.com/Johni0702/BetterPortals/blob/398e594e6e3bad62d52a91fd838e676dd4971f64/src/api/kotlin/de/johni0702/minecraft/betterportals/client/render/PortalRenderer.kt#L85-L108
Possibly related: Johni0702/BetterPortals#461

Note: I've reported this to HRZN back in July when their issue tracker was the one linked on CurseForge. Three months later I've got the reply that they're no longer working on Albedo and that I should report issues to the new maintainer (at which point the issue tracker on CF was still linking to them), so today Albedo came up again in a bug report on one of my mods, I noticed the new issue tracker and figured I might as well re-report those issues.
Thing is, I see no way to access my old reports (except the title which I got in the reply email) and don't recall exactly what they were about, so feel free to ask for details if my description is too short and I'll have another look at the code.

@Johni0702 Johni0702 added the bug Something isn't working label Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant