-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow hub access to production veda data store #53
Comments
Minor: I don't think that notebook is the best test. Easier test on the hub
Another random item from a different collection
@anayeaye it appears the bucket policy is not correct. Can you please share the policy internally (not on this ticket for review) |
I've started a branch to add this to the 2i2c config. Question should ESDIS and GHG instance get the same bucket access @anayeaye? They all currently only have staging.
|
Correction the branch is https://github.com/NASA-IMPACT/veda-hub-infrastructure/tree/veda-data-store |
All hubs in the VEDA universe should have GetObject and ListBucket perms veda-data-store. It is slowish but we are still trying to encourage sharing rather than duplicating data to every environment. EDIT we also need to add/confirm those instances are covered the bucket policy.
I will share it with you internally. I would be surprised if it is not correct because I have granted the same permissions as the hubs currently have for the staging bucket which can be accessed via. the hub. The rio cogeo info routine in the hub is easier to test than running the notebook example, thanks for the snippet!
|
@anayeaye yes I spoke to soon, the blocker is actually on the Hub side right now. One you approve 2i2c will deploy to staging hub, we can test, then do a 2nd PR pushing that bucket to all the VEDA related hubs. |
@anayeaye I've tested on staging that read access works. How would you like to test that other actions are blocked? Do you want try making a file in the bucket - is there a safe object to test removing? etc.... Then when you're happy I can open another PR To apply the fix to all the hubs/production.
|
@wildintellect I'm comfortable with the MCP bucket policy blocking. Would be nice to see things more specific in the hub role but it doesn't need to be. So I say we are ready for the PR to apply the fix to production. Thanks! |
PR completed 2i2c-org/infrastructure#4609 (comment) |
I ran a few of the veda-docs quickstart notebooks now and not getting anymore access denied errors. |
If it all looks good please comment on 2i2c-org/infrastructure#4535 (comment) and then we can close this. |
currently having a pydantic v2 version conflict problem in the hub so I used a new test :(. BUT I can read prod from hub.openveda.cloud ✅
|
@anayeaye can we close this ticket? |
What
Allow hubs to read production objects veda-data-store. We now have a stable production catalog and S3 data store and need to update our notebook examples to refer to the same data that users see in the dashboard.
Notes
In MCP I have updated the veda-data-store bucket policy to allow GetObject and ListBucket to these roles:
"arn:aws:iam::444055461661:role/nasa-veda-prod", "arn:aws:iam::444055461661:role/nasa-veda-staging"
.I think the hub has full Get, List, and Put set up for staging so the update might be here even though we do not want hub users to be able to Put in production (but the bucket will not allow that operation anyway): https://github.com/2i2c-org/infrastructure/blob/main/terraform/aws/projects/nasa-veda.tfvars#L47
AC
Testable with
The Download STAC Assets notebook should work using production
STAC_API_URL = "https://openveda.cloud/api/stac"
when run in the hub.The text was updated successfully, but these errors were encountered: