capgen: check handling of type attribute for ddts

[climbfuji]

Description

ccpp-framework/scripts/metavar.py

Line 303 in e86d0a7

prop_dict['kind'] = prop_dict['ddt_type']

We should check why the ddt_type attribute is copied into the kind attribute and then deleted. Maybe that is not necessary? Because of this behavior, PR #512 is introducing a workaround in add_var_debug_check (around line 1257 in scripts/suite_objects.py in the PR). Also, there is a workaround in ccpp_prebuild.py for this:

ccpp-framework/scripts/metadata_parser.py

Line 212 in 0eca5c2

# Workaround for Fortran DDTs incorrectly having the type of

Solution

Check whether this behavior is needed or not. If yes, provide more information in form of inline comments, maybe referring to this issue, so that we don't ask ourselves the same questions in a years time. If not, change the code and remove the workarounds as applicable.

Alternatives (optional)

n/a

Related to (optional)

n/a