Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub-cycling not working properly #632

Open
dustinswales opened this issue Jan 29, 2025 · 0 comments · Fixed by #633
Open

Sub-cycling not working properly #632

dustinswales opened this issue Jan 29, 2025 · 0 comments · Fixed by #633
Labels
bug For issues describing bugs, or PRs fixing bugs

Comments

@dustinswales
Copy link
Collaborator

Description

Sub-cycling not working in Capgen

Steps to Reproduce

Start with the var_compatability_test and add a subcycling to the SDF:
Replace
<scheme>effr_diag</scheme>
with

    <subcycle loop="1">
      <scheme>effr_diag</scheme>
    </subcycle>

When you try to run the test it will fail.
@dustinswales dustinswales added the bug For issues describing bugs, or PRs fixing bugs label Jan 29, 2025
@dustinswales dustinswales mentioned this issue Jan 29, 2025
Merged
dustinswales added a commit that referenced this issue Feb 25, 2025
@dustinswales @climbfuji
Capgen in SCM: Fix to allow for scheme subcycling. (#633)
dcb5ed5 
Overview
This PR contains changes to fix scheme subcycling in Capgen and extends
the var_compatability_test to exercise subcycling.
UPDATE: Added bugfix for suite-part list ordering (see change to
ccpp_suite.py).

Description
Create local group variable for subcycle indexing.
Fix bug (`self.loop` -> `self._loop`) in the Subcycle write phase, and
in ccpp_datafile.

User interface changes?: No

Fixes: #632 
Fixes: #634 

Testing:
Added to var_compatibility_test to exercise feature.

---------

Co-authored-by: Dom Heinzeller <[email protected]>
Co-authored-by: Steve Goldhaber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug For issues describing bugs, or PRs fixing bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Capgen in SCM: Fix to allow for scheme subcycling. dustinswales/ccpp-framework
1 participant
@dustinswales