Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eml2 refactor #191

Open
7 tasks done
dmullen17 opened this issue Jun 3, 2019 · 4 comments
Open
7 tasks done

eml2 refactor #191

dmullen17 opened this issue Jun 3, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@dmullen17
Copy link
Member

dmullen17 commented Jun 3, 2019

  • add_creator_id
  • edit_attribute
  • get_eml_attributes
  • qa_eml
  • qa_package
  • return_eml_units
  • which_in_eml
@dmullen17 dmullen17 added the enhancement New feature or request label Jun 3, 2019
@dmullen17 dmullen17 self-assigned this Jun 3, 2019
@jeanetteclark
Copy link
Contributor

removed which_in_eml as this is in arcticdatautils

@jeanetteclark
Copy link
Contributor

also proposing removal of return_eml_units and create_attributes_table since this functionality is now in EML

@jeanetteclark
Copy link
Contributor

okay, just pushed more commits that amount to a pretty aggressive culling of this package.

I removed: add_creator_id, which_in_eml, return_eml_units, create_attributes_table and qa_eml. The functionality of all of these functions is duplicated elsewhere, with the exception of add_creator_id, but I honestly couldn't see a good use for this function given how easy references are to use in EML 2.0. Definitely going to need feedback on all of this @dmullen17

@dmullen17
Copy link
Member Author

@jeanetteclark I agree with your reasoning for removing these functions. They're basically highly specific helpers that aren't all that useful or else now duplicated elsewhere.
👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants