Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arcticdatautils function pid_to_eml_physical only works for ADC #27

Open
dmullen17 opened this issue Jan 31, 2018 · 2 comments
Open

arcticdatautils function pid_to_eml_physical only works for ADC #27

dmullen17 opened this issue Jan 31, 2018 · 2 comments
Labels
open This issue has not yet been taken/assigned

Comments

@dmullen17
Copy link
Member

dmullen17 commented Jan 31, 2018

arcticdatautils::pid_to_eml_physical is one of most useful functions but specific fields only work for uploads to the Arctic Data Center.
For instance the following creates the online distribution info link:

phys@distribution[[1]]@online@url <- new("url", paste0("https://cn.dataone.org/cn/v2/resolve/", 
            x@identifier))

We should generalize this function to work across all (or alot) of the dataOne member nodes - definitely test ADC to start.

@isteves isteves added the open This issue has not yet been taken/assigned label Mar 1, 2018
@amoeba
Copy link

amoeba commented Mar 11, 2018

Hey @dmullen17, what's arcticdatacenter specific about that line of code? That would be correct for all nodes in the production environment. One bug I see is that it doesn't work for non-production nodes which would be a nice improvement.

@dmullen17
Copy link
Member Author

@amoeba Yea I specifically had test in mind when i wrote that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open This issue has not yet been taken/assigned
Projects
None yet
Development

No branches or pull requests

3 participants