Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistencies in MOP #5

Open
StroemPhi opened this issue Apr 21, 2021 · 2 comments
Open

Inconsistencies in MOP #5

StroemPhi opened this issue Apr 21, 2021 · 2 comments

Comments

@StroemPhi
Copy link
Member

StroemPhi commented Apr 21, 2021 •
edited
Loading

  • there seem to be issues with regard to the subsumption hierarchy of some classes
  • there are some classes that should be but are not being declared as disjoint (for why see here)
  • there seem to be wrong equivalent to axioms
@hujo91
Copy link
Collaborator

hujo91 commented Apr 21, 2021 •
edited
Loading

'cycloelimination' (MOP:0000564) should be a subclass of 'elimination reaction' (MOP:0000656), since it is just a special kind of elimination. Both classes should therefore not be equal on one sublevel below 'molecular process' (MOP:0000543).

StroemPhi added a commit that referenced this issue Apr 22, 2021
@StroemPhi
make cycloaddition an addition reaction #5
1e9d494
StroemPhi added a commit that referenced this issue Apr 22, 2021
@StroemPhi
make cycloelimination an 'elimination reaction' #5
60c5aa7
StroemPhi added a commit that referenced this issue Apr 22, 2021
@StroemPhi
make 'elimination reaction' & 'addition reaction' disjoint #5
41a58f5
StroemPhi added a commit that referenced this issue Apr 22, 2021
@StroemPhi
make 'accepting a hydron' & 'hydron donation' disjoint #5
eb0d556
StroemPhi added a commit that referenced this issue Apr 22, 2021
@StroemPhi
make 'breaking of covalent bond' & 'formation of covalent bond' disjo…
2491d1d 
…int #5
@StroemPhi
Copy link
Member Author

The above commits where made in https://github.com/NFDI4Chem/rxno/tree/MOP-propsed-changes to demonstrate some of the issues we've identified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@StroemPhi @hujo91