Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Offer Edit Endpoint URL #317

Open
Naapperas opened this issue Apr 24, 2023 · 0 comments · May be fixed by #339
Open

Change Offer Edit Endpoint URL #317

Naapperas opened this issue Apr 24, 2023 · 0 comments · May be fixed by #339
Assignees
@SimaoNery
Labels
maintenance newcomer friendly P1 Medium Priority

Comments

@Naapperas
Copy link
Member

The current URL for editing offers is of the form /offers/edit/:id while all others are of the form offers/:id/action. For the sake of consistency we should change the edit offer URL.

Since this could be a breaking change, only work on this for a new major release of the Backend API.
@SimaoNery SimaoNery self-assigned this Nov 17, 2023
@SimaoNery SimaoNery linked a pull request Nov 22, 2023 that will close this issue
Changed endpoint offer/edit/:id to offer/:id/edit #339
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimaoNery SimaoNery

Labels
maintenance newcomer friendly P1 Medium Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed endpoint offer/edit/:id to offer/:id/edit NIAEFEUP/nijobs-be
2 participants
@Naapperas @SimaoNery