Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed company offers route to /company/:companyid/offers #342

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Changed company offers route to /company/:companyid/offers #342

wants to merge 3 commits into from
+197 −161

Conversation

jacribeiro
Copy link

Closes #323

@render Render
Copy link

render bot commented Dec 6, 2023

Your Render PR Server URL is https://nijobs-backend-pr-342.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-clo98in5felc73butbpg.

Naapperas
Naapperas reviewed Dec 6, 2023
View reviewed changes
Copy link
Member

@Naapperas Naapperas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, just missing some tests @jacribeiro

@codecov Codecov
Copy link

codecov bot commented Dec 8, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (81bce7c) 90.33% compared to head (9fe28ba) 90.39%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #342      +/-   ##
===========================================
+ Coverage    90.33%   90.39%   +0.06%     
===========================================
  Files           54       54              
  Lines         1469     1468       -1     
  Branches       245      245              
===========================================
  Hits          1327     1327              
+ Misses         137      136       -1     
  Partials         5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

FranciscoCardoso913
FranciscoCardoso913 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@FranciscoCardoso913 FranciscoCardoso913 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to merge, nice job : )

Naapperas
Naapperas approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@Naapperas Naapperas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, don´t forget to rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FranciscoCardoso913 FranciscoCardoso913 FranciscoCardoso913 approved these changes

@Naapperas Naapperas Naapperas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move "Company offers" route to another place
3 participants
@jacribeiro @Naapperas @FranciscoCardoso913