From 5d8f484d9fd522079093a1e162c9327aa7ccf15d Mon Sep 17 00:00:00 2001 From: Nick Laws Date: Sat, 20 Apr 2024 13:41:17 -0600 Subject: [PATCH] rm check_connected_graph CommonOPF has is_connected(net::Network)::Bool --- docs/src/methods.md | 1 - src/BranchFlowModel.jl | 1 - src/checks.jl | 17 ----------------- test/runtests.jl | 1 - 4 files changed, 20 deletions(-) diff --git a/docs/src/methods.md b/docs/src/methods.md index 1bfa560..b5d79a4 100644 --- a/docs/src/methods.md +++ b/docs/src/methods.md @@ -31,7 +31,6 @@ rij xij zij check_soc_inequalities -check_connected_graph get_load_bal_shadow_prices voltage_values_by_time_bus current_values_by_time_edge diff --git a/src/BranchFlowModel.jl b/src/BranchFlowModel.jl index 5841417..2bbc35f 100644 --- a/src/BranchFlowModel.jl +++ b/src/BranchFlowModel.jl @@ -42,7 +42,6 @@ export # recover_voltage_current, # TODO validate this method zij, check_soc_inequalities, - check_connected_graph, get_load_bal_shadow_prices, voltage_values_by_time_bus, current_values_by_time_edge, diff --git a/src/checks.jl b/src/checks.jl index a1bee1c..19f45ba 100644 --- a/src/checks.jl +++ b/src/checks.jl @@ -40,23 +40,6 @@ function check_rank_one(m::JuMP.AbstractModel, p::Inputs{BranchFlowModel.MultiPh end -""" - check_connected_graph(p::Inputs{SinglePhase}) - -return true if only one connected graph; false otherwise - -this is a good check to do before attempting to solve a model because -if there is more than one sub-graph then it is likely the model will be infeasible -""" -function check_connected_graph(p::Inputs{SinglePhase}) - g = make_graph(p.busses, p.edges; directed=true) - if length(connected_components(g)) == 1 - return true - end - return false -end - - """ check_any_results_at_bounds(r::Results, p::Inputs{SinglePhase}) diff --git a/test/runtests.jl b/test/runtests.jl index 789418a..dbe02b6 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -420,7 +420,6 @@ end Ntimesteps = 1, relaxed = false # NLP ); - @test check_connected_graph(p) == true g = make_graph(p.busses, p.edges; directed=true) @test g.graph.ne == Graphs.nv(g) - 1 # a radial network has n_edges = n_vertices - 1 @test_warn "The per unit impedance values should be much less than one" check_unique_solution_conditions(p)