Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix old faulty class names that doesn't conform to standards #857

Open
snakefoot opened this issue Aug 15, 2022 · 1 comment
Open

Fix old faulty class names that doesn't conform to standards #857

snakefoot opened this issue Aug 15, 2022 · 1 comment
Labels
breaking change enhancement
Milestone
6.0

Comments

@snakefoot
Copy link
Contributor

NLog.Web/tests/Shared/ApiTests.cs

Lines 202 to 212 in 7a62c88

HashSet<string> oldFaultyClassNames = new HashSet<string>()
{
"AspNetApplicationValueLayoutRenderer",
"AspNetItemValueLayoutRenderer",
"AspNetMvcActionRenderer",
"AspNetMvcControllerRenderer",
"AspNetRequestContentLength",
"AspNetRequestHttpMethodRenderer",
"AspNetQueryStringLayoutRenderer",
"AspNetRequestReferrerRenderer",
"AspNetRequestRouteParametersRenderer",

@snakefoot snakefoot added this to the 6.0 milestone Aug 15, 2022
@bakgerman
Copy link
Contributor

bakgerman commented Aug 6, 2023 •
edited
Loading

Completed in a branch. I made sure git views these as renames and not delete then add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change enhancement
Projects
None yet
Milestone
6.0
Development

No branches or pull requests
2 participants
@bakgerman @snakefoot