Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move fms2io_interpolator_init to interpolator_init #1309

Open
mlee03 opened this issue Jul 31, 2023 · 0 comments · May be fixed by #1310
Open

move fms2io_interpolator_init to interpolator_init #1309

mlee03 opened this issue Jul 31, 2023 · 0 comments · May be fixed by #1310
Assignees
Labels
enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality.

Comments

@mlee03
Copy link
Contributor

mlee03 commented Jul 31, 2023

Is your feature request related to a problem? Please describe.
In interpolator_mod, the subroutine interpolator_init mainly calls the subroutine fms2io_interpolator_init. The code under fms2io_interpolator_init does not need to be in a separate subroutine. All initialization code can be moved to interpolator_init

Describe the solution you'd like
Combine interpolator_init and fms2io_interpolator_init; and remove fms2io_interpolator_init.

Describe alternatives you've considered
Leave it the way it is.

Additional context
Removing fms2io_interpolator_init will result in a cleaner code. Else, the users will wonder why there is a separate subroutine fms2io_interpolator_init.

@mlee03 mlee03 added the enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality. label Jul 31, 2023
@mlee03 mlee03 linked a pull request Jul 31, 2023 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant