From 4187f8162d101a9af13c701398b5cbe69490394b Mon Sep 17 00:00:00 2001 From: mlee03 Date: Thu, 27 Jun 2024 09:29:41 -0400 Subject: [PATCH 01/14] update numpy version --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index ecced82..54fbb9e 100644 --- a/setup.py +++ b/setup.py @@ -11,7 +11,7 @@ requirements = [ "f90nml>=1.1.0", - "numpy", + "numpy==1.26.4", "xarray", ] From 80f8fb962c49635ecf394d48ee615035ac87a1f0 Mon Sep 17 00:00:00 2001 From: mlee03 Date: Mon, 1 Jul 2024 15:39:04 -0400 Subject: [PATCH 02/14] test --- .github/workflows/pace_tests.yaml | 3 +- .github/workflows/pyshield_tests.yaml | 3 +- .github/workflows/translate.yaml | 68 ++++++++++++++------------- 3 files changed, 40 insertions(+), 34 deletions(-) diff --git a/.github/workflows/pace_tests.yaml b/.github/workflows/pace_tests.yaml index e4604b6..c3df6a6 100644 --- a/.github/workflows/pace_tests.yaml +++ b/.github/workflows/pace_tests.yaml @@ -8,4 +8,5 @@ jobs: pace_unit_tests: uses: mlee03/pace/.github/workflows/main_unit_tests.yaml@reusable_workflow with: - fv3_trigger: true + component_trigger: true + component_name: pyFV3 diff --git a/.github/workflows/pyshield_tests.yaml b/.github/workflows/pyshield_tests.yaml index fc9e70b..b94d190 100644 --- a/.github/workflows/pyshield_tests.yaml +++ b/.github/workflows/pyshield_tests.yaml @@ -8,4 +8,5 @@ jobs: pyshield_translate_tests: uses: mlee03/PySHiELD/.github/workflows/translate.yaml@reusing_workflows with: - fv3_trigger: true + component_trigger: true + component_name: pyFV3 diff --git a/.github/workflows/translate.yaml b/.github/workflows/translate.yaml index c7d8dcc..ba7198e 100644 --- a/.github/workflows/translate.yaml +++ b/.github/workflows/translate.yaml @@ -1,11 +1,15 @@ -name: "Translate PyFV3 test (subset)" +name: "Translate pyFV3 test (subset)" on: workflow_call: - inputs: - ndsl_trigger: - type: boolean - default: false - required: true + inputs: + component_trigger: + type: boolean + default: false + required: false + component_name: + type: string + default: 'None' + required: false push: pull_request: types: [opened, synchronize, reopened, ready_for_review, labeled, unlabeled] @@ -15,52 +19,51 @@ concurrency: group: ${{ github.workflow }}-${{ github.ref }} cancel-in-progress: true -env: - github_repository: ${{github.event.repository.name}} - jobs: - all_tests: + pyFV3_translate_tests: runs-on: ubuntu-latest container: image: ghcr.io/noaa-gfdl/miniforge:mpich steps: - - name: Checkout PyFV3 if NDSL triggers test - if: ${{inputs.ndsl_trigger}} + - name: Checkout PyFV3 for externally triggered + if: ${{inputs.component_trigger}} uses: actions/checkout@v4 with: submodules: 'recursive' - repository: noaa-gfdl/PyFV3 - path: PyFV3 + repository: noaa-gfdl/pyFV3 + path: pyFV3 - - name: Checkout either PyFV3 (!workflow_call) or NDSL (workflow_call) + - name: Checkout NDSL for externally triggered + if: ${{inputs.component_trigger}} uses: actions/checkout@v4 with: submodules: 'recursive' - path: ${{env.github_repository}} + path: pyFV3/${{inputs.component_name}} - - name: mv NDSL to PyFV3 if NDSL triggers test - if: ${{inputs.ndsl_trigger}} - run: | - cd ${GITHUB_WORKSPACE} - mv ${{env.github_repository}} PyFV3/. + - name: Checkout pyFV3 for interally triggered + if: ${{!inputs.component_trigger}} + uses: action/checkout@v4 + with: + submodules: 'recursive' + path: pyFV3 - - name: install packages to test NDSL in PyFV3 - if: ${{inputs.ndsl_trigger}} + - name: install packages to test NDSL in pyFV3 + if: ${{inputs.component_trigger}} run: | - cd ${GITHUB_WORKSPACE}/PyFV3 + cd ${GITHUB_WORKSPACE}/pyFV3 cd NDSL && pip3 install .[test] cd .. pip3 install .[test] - - name: Install packages to test only PyFV3 - if: ${{ ! inputs.ndsl_trigger }} + - name: Install packages to test only pyFV3 + if: ${{ ! inputs.component_trigger }} run : | - cd ${GITHUB_WORKSPACE}/PyFV3 + cd ${GITHUB_WORKSPACE}/pyFV3 pip install .[ndsl,test] - name: Prepare test_data run: | - cd ${GITHUB_WORKSPACE}/PyFV3 + cd ${GITHUB_WORKSPACE}/pyFV3 mkdir -p test_data && cd test_data wget https://portal.nccs.nasa.gov/datashare/astg/smt/pace-regression-data/8.1.3_c12_6ranks_standard.tar.gz tar -xzvf 8.1.3_c12_6ranks_standard.tar.gz --no-same-owner @@ -68,7 +71,7 @@ jobs: - name: Numpy FvTp2d run: | - cd ${GITHUB_WORKSPACE}/PyFV3 + cd ${GITHUB_WORKSPACE}/pyFV3 pytest \ -v -s --data_path=./test_data/8.1.3/c12_6ranks_standard/dycore \ --backend=numpy \ @@ -78,7 +81,7 @@ jobs: - name: Numpy D_SW run: | - cd ${GITHUB_WORKSPACE}/PyFV3 + cd ${GITHUB_WORKSPACE}/pyFV3 pytest \ -v -s --data_path=./test_data/8.1.3/c12_6ranks_standard/dycore \ --backend=numpy \ @@ -88,16 +91,17 @@ jobs: - name: Numpy Remapping run: | - cd ${GITHUB_WORKSPACE}/PyFV3 + cd ${GITHUB_WORKSPACE}/pyFV3 pytest \ -v -s --data_path=./test_data/8.1.3/c12_6ranks_standard/dycore \ --backend=numpy \ --which_modules=Remapping \ --threshold_overrides_file=./tests/savepoint/translate/overrides/standard.yaml \ ./tests/savepoint + - name: Orchestrated dace-cpu Acoustics run: | - cd ${GITHUB_WORKSPACE}/PyFV3 + cd ${GITHUB_WORKSPACE}/pyFV3 export FV3_DACEMODE=BuildAndRun export PACE_FLOAT_PRECISION=64 export PACE_TEST_N_THRESHOLD_SAMPLES=0 From 706f30b19d3aadbc08638e629901e67e03d787db Mon Sep 17 00:00:00 2001 From: mlee03 Date: Mon, 1 Jul 2024 15:40:12 -0400 Subject: [PATCH 03/14] test --- .github/workflows/translate.yaml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/translate.yaml b/.github/workflows/translate.yaml index ba7198e..f09883d 100644 --- a/.github/workflows/translate.yaml +++ b/.github/workflows/translate.yaml @@ -1,15 +1,15 @@ name: "Translate pyFV3 test (subset)" on: workflow_call: - inputs: - component_trigger: - type: boolean - default: false - required: false - component_name: - type: string - default: 'None' - required: false + inputs: + component_trigger: + type: boolean + default: false + required: false + component_name: + type: string + default: 'None' + required: false push: pull_request: types: [opened, synchronize, reopened, ready_for_review, labeled, unlabeled] From 01c3bce9f77745f3ac514e249c839e92f1cbbfd1 Mon Sep 17 00:00:00 2001 From: mlee03 Date: Mon, 1 Jul 2024 15:42:57 -0400 Subject: [PATCH 04/14] this again --- .github/workflows/translate.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/translate.yaml b/.github/workflows/translate.yaml index f09883d..dd8e039 100644 --- a/.github/workflows/translate.yaml +++ b/.github/workflows/translate.yaml @@ -26,7 +26,7 @@ jobs: image: ghcr.io/noaa-gfdl/miniforge:mpich steps: - - name: Checkout PyFV3 for externally triggered + - name: Checkout pyFV3 for externally triggered if: ${{inputs.component_trigger}} uses: actions/checkout@v4 with: @@ -41,7 +41,7 @@ jobs: submodules: 'recursive' path: pyFV3/${{inputs.component_name}} - - name: Checkout pyFV3 for interally triggered + - name: Checkout pyFV3 for internally triggered if: ${{!inputs.component_trigger}} uses: action/checkout@v4 with: From 6a4abe21397bfd1ec2d9bb18e50879255991e112 Mon Sep 17 00:00:00 2001 From: mlee03 Date: Mon, 1 Jul 2024 15:45:03 -0400 Subject: [PATCH 05/14] test --- .github/workflows/translate.yaml | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/.github/workflows/translate.yaml b/.github/workflows/translate.yaml index dd8e039..a245d77 100644 --- a/.github/workflows/translate.yaml +++ b/.github/workflows/translate.yaml @@ -1,15 +1,5 @@ name: "Translate pyFV3 test (subset)" on: - workflow_call: - inputs: - component_trigger: - type: boolean - default: false - required: false - component_name: - type: string - default: 'None' - required: false push: pull_request: types: [opened, synchronize, reopened, ready_for_review, labeled, unlabeled] From 92894754ced74a2310d48534c6f51bfc59b4ebc1 Mon Sep 17 00:00:00 2001 From: mlee03 Date: Mon, 1 Jul 2024 15:46:55 -0400 Subject: [PATCH 06/14] test --- .github/workflows/translate.yaml | 101 ++++--------------------------- 1 file changed, 11 insertions(+), 90 deletions(-) diff --git a/.github/workflows/translate.yaml b/.github/workflows/translate.yaml index a245d77..9f6b68b 100644 --- a/.github/workflows/translate.yaml +++ b/.github/workflows/translate.yaml @@ -1,5 +1,14 @@ name: "Translate pyFV3 test (subset)" on: + inputs: + component_trigger: + type: boolean + default: false + required: false + component_name: + type: string + default: 'None' + required: false push: pull_request: types: [opened, synchronize, reopened, ready_for_review, labeled, unlabeled] @@ -15,93 +24,5 @@ jobs: container: image: ghcr.io/noaa-gfdl/miniforge:mpich steps: - - - name: Checkout pyFV3 for externally triggered - if: ${{inputs.component_trigger}} - uses: actions/checkout@v4 - with: - submodules: 'recursive' - repository: noaa-gfdl/pyFV3 - path: pyFV3 - - - name: Checkout NDSL for externally triggered - if: ${{inputs.component_trigger}} - uses: actions/checkout@v4 - with: - submodules: 'recursive' - path: pyFV3/${{inputs.component_name}} - - - name: Checkout pyFV3 for internally triggered - if: ${{!inputs.component_trigger}} - uses: action/checkout@v4 - with: - submodules: 'recursive' - path: pyFV3 - - - name: install packages to test NDSL in pyFV3 - if: ${{inputs.component_trigger}} - run: | - cd ${GITHUB_WORKSPACE}/pyFV3 - cd NDSL && pip3 install .[test] - cd .. pip3 install .[test] - - - name: Install packages to test only pyFV3 - if: ${{ ! inputs.component_trigger }} - run : | - cd ${GITHUB_WORKSPACE}/pyFV3 - pip install .[ndsl,test] - - - name: Prepare test_data - run: | - cd ${GITHUB_WORKSPACE}/pyFV3 - mkdir -p test_data && cd test_data - wget https://portal.nccs.nasa.gov/datashare/astg/smt/pace-regression-data/8.1.3_c12_6ranks_standard.tar.gz - tar -xzvf 8.1.3_c12_6ranks_standard.tar.gz --no-same-owner - cd .. - - - name: Numpy FvTp2d - run: | - cd ${GITHUB_WORKSPACE}/pyFV3 - pytest \ - -v -s --data_path=./test_data/8.1.3/c12_6ranks_standard/dycore \ - --backend=numpy \ - --which_modules=FvTp2d \ - --threshold_overrides_file=./tests/savepoint/translate/overrides/standard.yaml \ - ./tests/savepoint - - - name: Numpy D_SW - run: | - cd ${GITHUB_WORKSPACE}/pyFV3 - pytest \ - -v -s --data_path=./test_data/8.1.3/c12_6ranks_standard/dycore \ - --backend=numpy \ - --which_modules=D_SW \ - --threshold_overrides_file=./tests/savepoint/translate/overrides/standard.yaml \ - ./tests/savepoint - - - name: Numpy Remapping - run: | - cd ${GITHUB_WORKSPACE}/pyFV3 - pytest \ - -v -s --data_path=./test_data/8.1.3/c12_6ranks_standard/dycore \ - --backend=numpy \ - --which_modules=Remapping \ - --threshold_overrides_file=./tests/savepoint/translate/overrides/standard.yaml \ - ./tests/savepoint - - - name: Orchestrated dace-cpu Acoustics - run: | - cd ${GITHUB_WORKSPACE}/pyFV3 - export FV3_DACEMODE=BuildAndRun - export PACE_FLOAT_PRECISION=64 - export PACE_TEST_N_THRESHOLD_SAMPLES=0 - export OMP_NUM_THREADS=1 - export PACE_LOGLEVEL=Debug - mpiexec -mca orte_abort_on_non_zero_status 1 -np 6 --oversubscribe pytest \ - -v -s --data_path=./test_data/8.1.3/c12_6ranks_standard/dycore \ - --backend=dace:cpu \ - -m parallel \ - --which_rank=0 \ - --which_modules=DynCore \ - --threshold_overrides_file=./tests/savepoint/translate/overrides/standard.yaml \ - ./tests/savepoint + - name: test + run: echo "HELLO" \ No newline at end of file From 3c8975b2b05cc13700cceeb77852b8029960928e Mon Sep 17 00:00:00 2001 From: mlee03 Date: Mon, 1 Jul 2024 15:47:52 -0400 Subject: [PATCH 07/14] test --- .github/workflows/translate.yaml | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/.github/workflows/translate.yaml b/.github/workflows/translate.yaml index 9f6b68b..33ff4e9 100644 --- a/.github/workflows/translate.yaml +++ b/.github/workflows/translate.yaml @@ -1,14 +1,15 @@ name: "Translate pyFV3 test (subset)" on: - inputs: - component_trigger: - type: boolean - default: false - required: false - component_name: - type: string - default: 'None' - required: false + workflow_call: + inputs: + component_trigger: + type: boolean + default: false + required: false + component_name: + type: string + default: 'None' + required: false push: pull_request: types: [opened, synchronize, reopened, ready_for_review, labeled, unlabeled] From 52227bfac824d6cc014d886be6d1350f149f0aec Mon Sep 17 00:00:00 2001 From: mlee03 Date: Mon, 1 Jul 2024 15:49:09 -0400 Subject: [PATCH 08/14] test --- .github/workflows/translate.yaml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/translate.yaml b/.github/workflows/translate.yaml index 33ff4e9..1668236 100644 --- a/.github/workflows/translate.yaml +++ b/.github/workflows/translate.yaml @@ -25,5 +25,11 @@ jobs: container: image: ghcr.io/noaa-gfdl/miniforge:mpich steps: - - name: test - run: echo "HELLO" \ No newline at end of file + + - name: Checkout pyFV3 for externally triggered + if: ${{inputs.component_trigger}} + uses: actions/checkout@v4 + with: + submodules: 'recursive' + repository: noaa-gfdl/pyFV3 + path: pyFV3 From 8e97fe8e4ee273febe9a6953476d75b6c8557b27 Mon Sep 17 00:00:00 2001 From: mlee03 Date: Mon, 1 Jul 2024 15:49:55 -0400 Subject: [PATCH 09/14] test --- .github/workflows/translate.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/translate.yaml b/.github/workflows/translate.yaml index 1668236..d20c98d 100644 --- a/.github/workflows/translate.yaml +++ b/.github/workflows/translate.yaml @@ -33,3 +33,10 @@ jobs: submodules: 'recursive' repository: noaa-gfdl/pyFV3 path: pyFV3 + + - name: Checkout NDSL for externally triggered + if: ${{inputs.component_trigger}} + uses: actions/checkout@v4 + with: + submodules: 'recursive' + path: pyFV3/${{inputs.component_name}} From b847a4c5e4ff951c11db2901b8f472176c67a014 Mon Sep 17 00:00:00 2001 From: mlee03 Date: Mon, 1 Jul 2024 15:50:51 -0400 Subject: [PATCH 10/14] test --- .github/workflows/translate.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/translate.yaml b/.github/workflows/translate.yaml index d20c98d..75603da 100644 --- a/.github/workflows/translate.yaml +++ b/.github/workflows/translate.yaml @@ -40,3 +40,10 @@ jobs: with: submodules: 'recursive' path: pyFV3/${{inputs.component_name}} + + - name: Checkout pyFV3 for internally triggered + if: ${{!inputs.component_trigger}} + uses: action/checkout@v4 + with: + submodules: 'recursive' + path: pyFV3 From 1f0bd8738e9de0b08e585a12d4d3aff71612f97f Mon Sep 17 00:00:00 2001 From: mlee03 Date: Mon, 1 Jul 2024 15:52:39 -0400 Subject: [PATCH 11/14] test --- .github/workflows/translate.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/translate.yaml b/.github/workflows/translate.yaml index 75603da..90abd27 100644 --- a/.github/workflows/translate.yaml +++ b/.github/workflows/translate.yaml @@ -41,9 +41,9 @@ jobs: submodules: 'recursive' path: pyFV3/${{inputs.component_name}} - - name: Checkout pyFV3 for internally triggered - if: ${{!inputs.component_trigger}} - uses: action/checkout@v4 + - name: Checkout pyFV3 for interally triggered + if: ${{ ! inputs.component_trigger }} + uses: actions/checkout@v4 with: submodules: 'recursive' path: pyFV3 From 58d1eca45dcb5b45ec3e60f55c07daecb4b0df1d Mon Sep 17 00:00:00 2001 From: mlee03 Date: Mon, 1 Jul 2024 15:54:02 -0400 Subject: [PATCH 12/14] test --- .github/workflows/translate.yaml | 68 ++++++++++++++++++++++++++++++++ 1 file changed, 68 insertions(+) diff --git a/.github/workflows/translate.yaml b/.github/workflows/translate.yaml index 90abd27..02d51b0 100644 --- a/.github/workflows/translate.yaml +++ b/.github/workflows/translate.yaml @@ -47,3 +47,71 @@ jobs: with: submodules: 'recursive' path: pyFV3 + + - name: install packages to test NDSL in pyFV3 + if: ${{inputs.component_trigger}} + run: | + cd ${GITHUB_WORKSPACE}/pyFV3 + cd NDSL && pip3 install .[test] + cd .. pip3 install .[test] + + - name: Install packages to test only pyFV3 + if: ${{ ! inputs.component_trigger }} + run : | + cd ${GITHUB_WORKSPACE}/pyFV3 + pip install .[ndsl,test] + + - name: Prepare test_data + run: | + cd ${GITHUB_WORKSPACE}/pyFV3 + mkdir -p test_data && cd test_data + wget https://portal.nccs.nasa.gov/datashare/astg/smt/pace-regression-data/8.1.3_c12_6ranks_standard.tar.gz + tar -xzvf 8.1.3_c12_6ranks_standard.tar.gz --no-same-owner + cd .. + + - name: Numpy FvTp2d + run: | + cd ${GITHUB_WORKSPACE}/pyFV3 + pytest \ + -v -s --data_path=./test_data/8.1.3/c12_6ranks_standard/dycore \ + --backend=numpy \ + --which_modules=FvTp2d \ + --threshold_overrides_file=./tests/savepoint/translate/overrides/standard.yaml \ + ./tests/savepoint + + - name: Numpy D_SW + run: | + cd ${GITHUB_WORKSPACE}/pyFV3 + pytest \ + -v -s --data_path=./test_data/8.1.3/c12_6ranks_standard/dycore \ + --backend=numpy \ + --which_modules=D_SW \ + --threshold_overrides_file=./tests/savepoint/translate/overrides/standard.yaml \ + ./tests/savepoint + + - name: Numpy Remapping + run: | + cd ${GITHUB_WORKSPACE}/pyFV3 + pytest \ + -v -s --data_path=./test_data/8.1.3/c12_6ranks_standard/dycore \ + --backend=numpy \ + --which_modules=Remapping \ + --threshold_overrides_file=./tests/savepoint/translate/overrides/standard.yaml \ + ./tests/savepoint + + - name: Orchestrated dace-cpu Acoustics + run: | + cd ${GITHUB_WORKSPACE}/pyFV3 + export FV3_DACEMODE=BuildAndRun + export PACE_FLOAT_PRECISION=64 + export PACE_TEST_N_THRESHOLD_SAMPLES=0 + export OMP_NUM_THREADS=1 + export PACE_LOGLEVEL=Debug + mpiexec -mca orte_abort_on_non_zero_status 1 -np 6 --oversubscribe pytest \ + -v -s --data_path=./test_data/8.1.3/c12_6ranks_standard/dycore \ + --backend=dace:cpu \ + -m parallel \ + --which_rank=0 \ + --which_modules=DynCore \ + --threshold_overrides_file=./tests/savepoint/translate/overrides/standard.yaml \ + ./tests/savepoint From e505c073dbf8405f26d767f529441dc49c6d51c2 Mon Sep 17 00:00:00 2001 From: mlee03 Date: Tue, 2 Jul 2024 08:01:19 -0400 Subject: [PATCH 13/14] test --- .github/workflows/pace_tests.yaml | 4 ++-- .github/workflows/pyshield_tests.yaml | 2 +- .github/workflows/translate.yaml | 22 +++++++--------------- 3 files changed, 10 insertions(+), 18 deletions(-) diff --git a/.github/workflows/pace_tests.yaml b/.github/workflows/pace_tests.yaml index c3df6a6..109eedd 100644 --- a/.github/workflows/pace_tests.yaml +++ b/.github/workflows/pace_tests.yaml @@ -1,11 +1,11 @@ -name: "Pace unit tests" +name: "Pace main tests" on: push: pull_request: types: [opened, synchronize, reopened, ready_for_review, labeled, unlabeled] jobs: - pace_unit_tests: + pace_main_tests: uses: mlee03/pace/.github/workflows/main_unit_tests.yaml@reusable_workflow with: component_trigger: true diff --git a/.github/workflows/pyshield_tests.yaml b/.github/workflows/pyshield_tests.yaml index b94d190..b10f8d0 100644 --- a/.github/workflows/pyshield_tests.yaml +++ b/.github/workflows/pyshield_tests.yaml @@ -1,4 +1,4 @@ -name: "pySHiELD Translate tests" +name: "pySHiELD translate tests" on: push: pull_request: diff --git a/.github/workflows/translate.yaml b/.github/workflows/translate.yaml index 02d51b0..3225dc1 100644 --- a/.github/workflows/translate.yaml +++ b/.github/workflows/translate.yaml @@ -8,7 +8,7 @@ on: required: false component_name: type: string - default: 'None' + default: '' required: false push: pull_request: @@ -26,7 +26,7 @@ jobs: image: ghcr.io/noaa-gfdl/miniforge:mpich steps: - - name: Checkout pyFV3 for externally triggered + - name: External trigger Checkout pyFV3 if: ${{inputs.component_trigger}} uses: actions/checkout@v4 with: @@ -34,28 +34,20 @@ jobs: repository: noaa-gfdl/pyFV3 path: pyFV3 - - name: Checkout NDSL for externally triggered - if: ${{inputs.component_trigger}} + - name: Checkout hash that triggered CI uses: actions/checkout@v4 with: submodules: 'recursive' path: pyFV3/${{inputs.component_name}} - - name: Checkout pyFV3 for interally triggered - if: ${{ ! inputs.component_trigger }} - uses: actions/checkout@v4 - with: - submodules: 'recursive' - path: pyFV3 - - - name: install packages to test NDSL in pyFV3 + - name: External trigger install NDSL packages if: ${{inputs.component_trigger}} run: | cd ${GITHUB_WORKSPACE}/pyFV3 - cd NDSL && pip3 install .[test] - cd .. pip3 install .[test] + cd NDSL && pip3 install .[test] && cd ../ + pip3 install .[test] - - name: Install packages to test only pyFV3 + - name: Install pyFV3 packages if: ${{ ! inputs.component_trigger }} run : | cd ${GITHUB_WORKSPACE}/pyFV3 From 223b8ad29e5e2385bd513181701b855a335a2b8c Mon Sep 17 00:00:00 2001 From: mlee03 Date: Tue, 2 Jul 2024 12:15:41 -0400 Subject: [PATCH 14/14] delete extra spacing --- .github/workflows/translate.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/translate.yaml b/.github/workflows/translate.yaml index c9d242b..a3512aa 100644 --- a/.github/workflows/translate.yaml +++ b/.github/workflows/translate.yaml @@ -3,7 +3,7 @@ on: workflow_call: inputs: component_trigger: - type: boolean + type: boolean default: false required: false component_name: