Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand IDF bug with HVACTemplate:System:DedicatedOutdoorAir for Heat Recovery Type 'Enthalpy' (v24.2) #10895

Open
sbuck99 opened this issue Jan 14, 2025 · 1 comment · May be fixed by #10904
Open

Expand IDF bug with HVACTemplate:System:DedicatedOutdoorAir for Heat Recovery Type 'Enthalpy' (v24.2) #10895

sbuck99 opened this issue Jan 14, 2025 · 1 comment · May be fixed by #10904
Assignees
@jmarrec
Labels
Defect Includes code to repair a defect in EnergyPlus

Comments

@sbuck99
Copy link

sbuck99 commented Jan 14, 2025 •
edited by jmarrec
Loading

Setting Heat Recovery Type to Enthalpy in the HVACTemplate:System:DedicatedOutdoorAir template yields an error with some configurations:

   ** Severe  ** Duplicate name found for object of type "Table:IndependentVariable" named "DOAS airFlowRatio". Overwriting existing object.
   ** Severe  ** Duplicate name found for object of type "Table:IndependentVariableList" named "DOAS effIndVarList". Overwriting existing object.
   ** Severe  ** Duplicate name found for object of type "Table:Lookup" named "DOAS SenEffectivenessTable". Overwriting existing object.

Reviewing the expidf and indeed duplicate tables are found.

Here is the object:

  HVACTemplate:System:DedicatedOutdoorAir,
    DOAS,                    !- Name
    Always On,                !- System Availability Schedule Name
    DirectIntoZone,          !- Air Outlet Type
    autosize,                !- Supply Fan Flow Rate {m3/s}
    0.7,                     !- Supply Fan Total Efficiency
    1000,                    !- Supply Fan Delta Pressure {Pa}
    0.9,                     !- Supply Fan Motor Efficiency
    1,                       !- Supply Fan Motor in Air Stream Fraction
    DrawThrough,             !- Supply Fan Placement
    HeatExchangerAssistedDX,            !- Cooling Coil Type
    ALWAYS OFF DOAS,                        !- Cooling Coil Availability Schedule Name
    FixedSetpoint,           !- Cooling Coil Setpoint Control Type
    12.8,                    !- Cooling Coil Design Setpoint {C}
    ,                        !- Cooling Coil Setpoint Schedule Name
    15.6,                    !- Cooling Coil Setpoint at Outdoor Dry-Bulb Low {C}
    15.6,                    !- Cooling Coil Reset Outdoor Dry-Bulb Low {C}
    12.8,                    !- Cooling Coil Setpoint at Outdoor Dry-Bulb High {C}
    23.3,                    !- Cooling Coil Reset Outdoor Dry-Bulb High {C}
    autosize,                !- DX Cooling Coil Gross Rated Total Capacity {W}
    autosize,                !- DX Cooling Coil Gross Rated Sensible Heat Ratio
    3,                       !- DX Cooling Coil Gross Rated COP {W/W}
    Electric,                !- Heating Coil Type
    ALWAYS OFF DOAS,                        !- Heating Coil Availability Schedule Name
    FixedSetpoint,           !- Heating Coil Setpoint Control Type
    12.2,                    !- Heating Coil Design Setpoint {C}
    ,                        !- Heating Coil Setpoint Schedule Name
    15,                      !- Heating Coil Setpoint at Outdoor Dry-Bulb Low {C}
    7.8,                     !- Heating Coil Reset Outdoor Dry-Bulb Low {C}
    12.2,                    !- Heating Coil Setpoint at Outdoor Dry-Bulb High {C}
    12.2,                    !- Heating Coil Reset Outdoor Dry-Bulb High {C}
    0.8,                     !- Gas Heating Coil Efficiency
    ,                        !- Gas Heating Coil Parasitic Electric Load {W}
    **Enthalpy,                !- Heat Recovery Type**
    0.7,                     !- Heat Recovery Sensible Effectiveness
    0.65,                    !- Heat Recovery Latent Effectiveness
    Plate,                   !- Heat Recovery Heat Exchanger Type
    MinimumExhaustTemperature,  !- Heat Recovery Frost Control Type
    None,                    !- Dehumidification Control Type
    0.00924,                 !- Dehumidification Setpoint {kgWater/kgDryAir}
    None,                    !- Humidifier Type
    ,                        !- Humidifier Availability Schedule Name
    0.000001,                !- Humidifier Rated Capacity {m3/s}
    2690,                    !- Humidifier Rated Electric Power {W}
    0.003,                   !- Humidifier Constant Setpoint {kgWater/kgDryAir}
    ,                        !- Dehumidification Setpoint Schedule Name
    ;                        !- Humidifier Setpoint Schedule Name

Setting the Heat Recovery Type to 'None' makes the error go away.

File is attached for reproducibility of bug (single zone example).

DOAS_error.idf.txt
@jmarrec jmarrec self-assigned this Jan 21, 2025
@jmarrec jmarrec added the Defect Includes code to repair a defect in EnergyPlus label Jan 21, 2025
@jmarrec
Copy link
Contributor

jmarrec commented Jan 21, 2025

@sbuck99 Thank you for the defect file attached, it's always nice when it's as small as possible!

jmarrec added a commit to jmarrec/EnergyPlus that referenced this issue Jan 21, 2025
@jmarrec
Add failing ExpandObjects file for NREL#10895
92486d0
jmarrec added a commit to jmarrec/EnergyPlus that referenced this issue Jan 21, 2025
@jmarrec
Fix NREL#10895 - Use unique TableLookup names to avoid duplicates
3464e99
jmarrec added a commit to jmarrec/EnergyPlus that referenced this issue Jan 23, 2025
@jmarrec
Add failing ExpandObjects file for NREL#10895
1bd4f1b 
```bash
$ ninja && ctest -R TwoHX
test 800
    Start 800: integration.HVACTemplate-5ZonePTAC-DOAS-TwoHX

800: Test command: /usr/bin/cmake "-DSOURCE_DIR=/media/DataExt4/Software/Others/EnergyPlus" "-DBINARY_DIR=/media/DataExt4/Software/Others/EnergyPlus-build-release" "-DENERGYPLUS_EXE=/media/DataExt4/Software/Others/EnergyPlus-build-release/Products/energyplus-25.1.0" "-DIDF_FILE=HVACTemplate-5ZonePTAC-DOAS-TwoHX.idf" "-DEPW_FILE=USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw" "-DENERGYPLUS_FLAGS=-x -D -r" "-DBUILD_FORTRAN=ON" "-DTEST_FILE_FOLDER=testfiles" "-DRUN_CALLGRIND:BOOL=FALSE" "-DVALGRIND=" "-DRUN_PERF_STAT:BOOL=FALSE" "-DPERF=" "-P" "/media/DataExt4/Software/Others/EnergyPlus/cmake/RunSimulation.cmake"
800: Working Directory: /media/DataExt4/Software/Others/EnergyPlus-build-release/testfiles
800: Test timeout computed to be: 10000000
800: ExpandObjects Started.
800:  Begin reading Energy+.idd file.
800:  Done reading Energy+.idd file.
800: ExpandObjects Finished with Error(s). Time:     0.046
800: EnergyPlus Starting
800: EnergyPlus, Version 25.1.0-92486d0f1f, YMD=2025.01.23 10:15
800: **FATAL:Errors occurred on processing input file. Preceding condition(s) cause termination.
800: EnergyPlus Run Time=00hr 00min  0.09sec
800: Program terminated: EnergyPlus Terminated--Error(s) Detected.
800: Test Failed
1/1 Test NREL#800: integration.HVACTemplate-5ZonePTAC-DOAS-TwoHX ...***Failed  Error regular expression found in output. Regex=[Test Failed]  0.43 sec

0% tests passed, 1 tests failed out of 1

Total Test time (real) =   0.53 sec

The following tests FAILED:
	800 - integration.HVACTemplate-5ZonePTAC-DOAS-TwoHX (Failed)

$ cat testfiles/HVACTemplate-5ZonePTAC-DOAS-TwoHX/eplusout.err 
Program Version,EnergyPlus, Version 25.1.0-92486d0f1f, YMD=2025.01.23 10:15,
   ** Severe  ** Duplicate name found for object of type "Table:IndependentVariable" named "DOAS airFlowRatio". Overwriting existing object.
   ** Severe  ** Duplicate name found for object of type "Table:IndependentVariableList" named "DOAS effIndVarList". Overwriting existing object.
   ** Severe  ** Duplicate name found for object of type "Table:Lookup" named "DOAS SenEffectivenessTable". Overwriting existing object.
   **  Fatal  ** Errors occurred on processing input file. Preceding condition(s) cause termination.
   ...Summary of Errors that led to program termination:
   ..... Reference severe error count=3
   ..... Last severe error=Duplicate name found for object of type "Table:Lookup" named "DOAS SenEffectivenessTable". Overwriting existing object.
   ************* Warning:  Node connection errors not checked - most system input has not been read (see previous warning).
   ************* Fatal error -- final processing.  Program exited before simulations began.  See previous error messages.
   ************* EnergyPlus Warmup Error Summary. During Warmup: 0 Warning; 0 Severe Errors.
   ************* EnergyPlus Sizing Error Summary. During Sizing: 0 Warning; 0 Severe Errors.
   ************* EnergyPlus Terminated--Fatal Error Detected. 0 Warning; 3 Severe Errors; Elapsed Time=00hr 00min  0.09sec
```
jmarrec added a commit to jmarrec/EnergyPlus that referenced this issue Jan 23, 2025
@jmarrec
Fix NREL#10895 - Use unique TableLookup names to avoid duplicates
9ca681b 
```bash
diff -u testfiles/HVACTemplate-5ZonePTAC-DOAS-TwoHX-ori/eplusout.expidf testfiles/HVACTemplate-5ZonePTAC-DOAS-TwoHX/eplusout.expidf
```

```diff
--- testfiles/HVACTemplate-5ZonePTAC-DOAS-TwoHX-ori/eplusout.expidf	2025-01-23 10:15:14.389466278 +0100
+++ testfiles/HVACTemplate-5ZonePTAC-DOAS-TwoHX/eplusout.expidf	2025-01-23 10:17:46.386621036 +0100
@@ -3469,13 +3469,13 @@
   ,                                                        !- Initial Defrost Time Fraction {dimensionless}
   ,                                                        !- Rate of Defrost Time Fraction Increase {1/K}
   No,                                                      !- Economizer Lockout
-  DOAS SenEffectivenessTable,                              !- Sensible Effectiveness of Heating Air Flow Curve Name
+  DOAS Cooling Coil Heat Exchanger SenEffectivenessTable,  !- Sensible Effectiveness of Heating Air Flow Curve Name
   ,                                                        !- Latent Effectiveness of Heating Air Flow Curve Name
-  DOAS SenEffectivenessTable,                              !- Sensible Effectiveness of Cooling Air Flow Curve Name
+  DOAS Cooling Coil Heat Exchanger SenEffectivenessTable,  !- Sensible Effectiveness of Cooling Air Flow Curve Name
   ;                                                        !- Latent Effectiveness of Cooling Air Flow Curve Name

 Table:IndependentVariable,
-  DOAS airFlowRatio,                                       !- Name
+  DOAS Cooling Coil Heat Exchanger airFlowRatio,           !- Name
   Linear,                                                  !- Interpolation Method
   Linear,                                                  !- Extrapolation Method
   0.0,                                                     !- Minimum Value
@@ -3489,12 +3489,12 @@
   1.0;                                                     !- Value 2

 Table:IndependentVariableList,
-  DOAS effIndVarList,                                      !- Name
-  DOAS airFlowRatio;                                       !- Independent Variable 1 Name
+  DOAS Cooling Coil Heat Exchanger effIndVarList,          !- Name
+  DOAS Cooling Coil Heat Exchanger airFlowRatio;           !- Independent Variable 1 Name

 Table:Lookup,
-  DOAS SenEffectivenessTable,                              !- Name
-  DOAS effIndVarList,                                      !- Independent Variable List Name
+  DOAS Cooling Coil Heat Exchanger SenEffectivenessTable,  !- Name
+  DOAS Cooling Coil Heat Exchanger effIndVarList,          !- Independent Variable List Name
   DivisorOnly,                                             !- Normalization Method
   0.699999988,                                             !- Normalization Divisor
   0.0,                                                     !- Minimum Output
@@ -3719,13 +3719,13 @@
   0.083,                                                   !- Initial Defrost Time Fraction
   0.012,                                                   !- Rate of Defrost Time Fraction Increase
   Yes,                                                     !- Economizer Lockout
-  DOAS SenEffectivenessTable,                              !- Sensible Effectiveness of Heating Air Flow Curve Name
-  DOAS LatEffectivenessTable,                              !- Latent Effectiveness of Heating Air Flow Curve Name
-  DOAS SenEffectivenessTable,                              !- Sensible Effectiveness of Cooling Air Flow Curve Name
-  DOAS LatEffectivenessTable;                              !- Latent Effectiveness of Cooling Air Flow Curve Name
+  DOAS Heat Recovery SenEffectivenessTable,                !- Sensible Effectiveness of Heating Air Flow Curve Name
+  DOAS Heat Recovery LatEffectivenessTable,                !- Latent Effectiveness of Heating Air Flow Curve Name
+  DOAS Heat Recovery SenEffectivenessTable,                !- Sensible Effectiveness of Cooling Air Flow Curve Name
+  DOAS Heat Recovery LatEffectivenessTable;                !- Latent Effectiveness of Cooling Air Flow Curve Name

 Table:IndependentVariable,
-  DOAS airFlowRatio,                                       !- Name
+  DOAS Heat Recovery airFlowRatio,                         !- Name
   Linear,                                                  !- Interpolation Method
   Linear,                                                  !- Extrapolation Method
   0.0,                                                     !- Minimum Value
@@ -3739,12 +3739,12 @@
   1.0;                                                     !- Value 2

 Table:IndependentVariableList,
-  DOAS effIndVarList,                                      !- Name
-  DOAS airFlowRatio;                                       !- Independent Variable 1 Name
+  DOAS Heat Recovery effIndVarList,                        !- Name
+  DOAS Heat Recovery airFlowRatio;                         !- Independent Variable 1 Name

 Table:Lookup,
-  DOAS SenEffectivenessTable,                              !- Name
-  DOAS effIndVarList,                                      !- Independent Variable List Name
+  DOAS Heat Recovery SenEffectivenessTable,                !- Name
+  DOAS Heat Recovery effIndVarList,                        !- Independent Variable List Name
   DivisorOnly,                                             !- Normalization Method
   0.699999988,                                             !- Normalization Divisor
   0.0,                                                     !- Minimum Output
@@ -3757,8 +3757,8 @@
   0.699999988;                                             !- Value 2

 Table:Lookup,
-  DOAS LatEffectivenessTable,                              !- Name
-  DOAS effIndVarList,                                      !- Independent Variable List Name
+  DOAS Heat Recovery LatEffectivenessTable,                !- Name
+  DOAS Heat Recovery effIndVarList,                        !- Independent Variable List Name
   DivisorOnly,                                             !- Normalization Method
   0.649999976,                                             !- Normalization Divisor
   0.0,                                                     !- Minimum Output
```
@jmarrec jmarrec linked a pull request Jan 23, 2025 that will close this issue
Open
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmarrec jmarrec

Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Milestone
No milestone
2 participants
@jmarrec @sbuck99