Skip to content

Commit

Permalink
pulling master for CI to run
Browse files Browse the repository at this point in the history
  • Loading branch information
@Sashadf1
Sashadf1 committed Feb 26, 2025
2 parents b1ef25b + e222dcb commit b0cf68b
Show file tree
Hide file tree
Showing 20 changed files with 317 additions and 281 deletions.
6 changes: 3 additions & 3 deletions HPXMLtoOpenStudio/measure.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>hpxm_lto_openstudio</name>
<uid>b1543b30-9465-45ff-ba04-1d1f85e763bc</uid>
<version_id>91b1f9f7-e9fc-4c22-9072-a5847f2bb04f</version_id>
<version_modified>2025-02-24T23:30:47Z</version_modified>
<version_id>d92a5185-cd4e-4a2e-bf62-4c999fa35bde</version_id>
<version_modified>2025-02-20T18:38:37Z</version_modified>
<xml_checksum>D8922A73</xml_checksum>
<class_name>HPXMLtoOpenStudio</class_name>
<display_name>HPXML to OpenStudio Translator</display_name>
Expand Down Expand Up @@ -723,7 +723,7 @@
<filename>test_hvac.rb</filename>
<filetype>rb</filetype>
<usage_type>test</usage_type>
<checksum>088B98CB</checksum>
<checksum>E30F0328</checksum>
</file>
<file>
<filename>test_hvac_sizing.rb</filename>
Expand Down
16 changes: 8 additions & 8 deletions HPXMLtoOpenStudio/tests/test_hvac.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -697,21 +697,21 @@ def test_air_to_air_heat_pump_var_speed_detailed_performance
assert_equal(1, model.getCoilCoolingDXMultiSpeeds.size)
clg_coil = model.getCoilCoolingDXMultiSpeeds[0]
assert_equal(2, clg_coil.stages.size)
[4.61, 2.88].each_with_index do |cop, i|
[4.51, 2.80].each_with_index do |cop, i|
assert_in_epsilon(cop, clg_coil.stages[i].grossRatedCoolingCOP, 0.01)
end
[3435, 10726].each_with_index do |clg_capacity, i|
[3494, 10721].each_with_index do |clg_capacity, i|
assert_in_epsilon(clg_capacity, clg_coil.stages[i].grossRatedTotalCoolingCapacity.get, 0.01)
end

# Check heating coil
assert_equal(1, model.getCoilHeatingDXMultiSpeeds.size)
htg_coil = model.getCoilHeatingDXMultiSpeeds[0]
assert_equal(2, htg_coil.stages.size)
[4.75, 3.59].each_with_index do |cop, i|
[4.70, 3.54].each_with_index do |cop, i|
assert_in_epsilon(cop, htg_coil.stages[i].grossRatedHeatingCOP, 0.01)
end
[2927, 10376].each_with_index do |htg_capacity, i|
[2898, 10324].each_with_index do |htg_capacity, i|
assert_in_epsilon(htg_capacity, htg_coil.stages[i].grossRatedHeatingCapacity.get, 0.01)
end

Expand Down Expand Up @@ -965,21 +965,21 @@ def test_mini_split_heat_pump_detailed_performance
assert_equal(1, model.getCoilCoolingDXMultiSpeeds.size)
clg_coil = model.getCoilCoolingDXMultiSpeeds[0]
assert_equal(2, clg_coil.stages.size)
[4.06, 3.33].each_with_index do |cop, i|
[3.77, 2.49].each_with_index do |cop, i|
assert_in_epsilon(cop, clg_coil.stages[i].grossRatedCoolingCOP, 0.01)
end
[3041, 12557].each_with_index do |clg_capacity, i|
[2668, 10720].each_with_index do |clg_capacity, i|
assert_in_epsilon(clg_capacity, clg_coil.stages[i].grossRatedTotalCoolingCapacity.get, 0.01)
end

# Check heating coil
assert_equal(1, model.getCoilHeatingDXMultiSpeeds.size)
htg_coil = model.getCoilHeatingDXMultiSpeeds[0]
assert_equal(2, htg_coil.stages.size)
[4.82, 3.23].each_with_index do |cop, i|
[3.48, 2.79].each_with_index do |cop, i|
assert_in_epsilon(cop, htg_coil.stages[i].grossRatedHeatingCOP, 0.01)
end
[3557, 16426].each_with_index do |htg_capacity, i|
[3339, 13519].each_with_index do |htg_capacity, i|
assert_in_epsilon(htg_capacity, htg_coil.stages[i].grossRatedHeatingCapacity.get, 0.01)
end

Expand Down
2 changes: 1 addition & 1 deletion docs/source/workflow_inputs.rst
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4504,7 +4504,7 @@ A detailed solar hot water system is entered as a ``/HPXML/Building/BuildingDeta
``CollectorAzimuth`` or ``CollectorOrientation`` integer or string deg or direction >= 0, <= 359 or See [#]_ Yes Direction panels face (clockwise from North)
``CollectorTilt`` double deg >= 0, <= 90 Yes Tilt relative to horizontal
``CollectorRatedOpticalEfficiency`` double frac > 0, < 1 Yes Rated optical efficiency [#]_
``CollectorRatedThermalLosses`` double Btu/hr-ft2-R > 0 Yes Rated thermal losses [#]_
``CollectorRatedThermalLosses`` double Btu/hr-ft2-F > 0 Yes Rated thermal losses [#]_
``StorageVolume`` double gal > 0 No See [#]_ Hot water storage volume
``ConnectedTo`` idref See [#]_ Yes Connected water heater
================================================ ================= ================ ======================== ======== ======== ==============================
Expand Down
90 changes: 45 additions & 45 deletions workflow/hpxml_inputs.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2210,20 +2210,20 @@
"heat_pump_cooling_compressor_type": "variable speed",
"heat_pump_heating_capacity_retention_fraction": null,
"heat_pump_heating_capacity_retention_temp": null,
"heat_pump_cooling_efficiency": 17.25,
"heat_pump_heating_efficiency": 10.0,
"heat_pump_cooling_efficiency": 17.5,
"heat_pump_heating_efficiency": 9.5,
"hvac_perf_data_capacity_type": "Absolute capacities",
"hvac_perf_data_heating_outdoor_temperatures": "47.0, 17.0, 5.0",
"hvac_perf_data_heating_min_speed_capacities": "10000, 4200, 1900",
"hvac_perf_data_heating_max_speed_capacities": "36000, 24800, 19900",
"hvac_perf_data_heating_min_speed_cops": "4.73, 1.84, 0.81",
"hvac_perf_data_heating_max_speed_cops": "3.44, 2.66, 2.28",
"hvac_perf_data_heating_min_speed_capacities": "9900, 3600, 1100",
"hvac_perf_data_heating_max_speed_capacities": "35800, 24600, 19700",
"hvac_perf_data_heating_min_speed_cops": "4.68, 1.57, 0.47",
"hvac_perf_data_heating_max_speed_cops": "3.4, 2.58, 2.63",
"hvac_perf_data_cooling_outdoor_temperatures": "95.0, 82.0",
"hvac_perf_data_cooling_min_speed_capacities": "11700, 13200",
"hvac_perf_data_cooling_max_speed_capacities": "36000, 40000",
"hvac_perf_data_cooling_min_speed_cops": "4.57, 6.34",
"hvac_perf_data_cooling_max_speed_cops": "2.71, 3.53",
"additional_properties": "HeatPump=YORK HMH7|HeatPumpAHRICert#=208613158"
"hvac_perf_data_cooling_min_speed_capacities": "11900, 13400",
"hvac_perf_data_cooling_max_speed_capacities": "36000, 40500",
"hvac_perf_data_cooling_min_speed_cops": "4.47, 6.33",
"hvac_perf_data_cooling_max_speed_cops": "2.64, 3.46",
"additional_properties": "HeatPump=YORK HMH7|HeatPumpAHRICert#=206921308"
},
"sample_files/base-hvac-air-to-air-heat-pump-var-speed-detailed-performance-heating-only.xml": {
"parent_hpxml": "sample_files/base-hvac-air-to-air-heat-pump-var-speed-detailed-performance.xml",
Expand All @@ -2236,10 +2236,10 @@
"sample_files/base-hvac-air-to-air-heat-pump-var-speed-detailed-performance-normalized-capacities.xml": {
"parent_hpxml": "sample_files/base-hvac-air-to-air-heat-pump-var-speed-detailed-performance.xml",
"hvac_perf_data_capacity_type": "Normalized capacity fractions",
"hvac_perf_data_heating_min_speed_capacities": "0.28, 0.12, 0.05",
"hvac_perf_data_heating_max_speed_capacities": "1.0, 0.69, 0.55",
"hvac_perf_data_cooling_min_speed_capacities": "0.325, 0.37",
"hvac_perf_data_cooling_max_speed_capacities": "1.0, 1.11"
"hvac_perf_data_heating_min_speed_capacities": "0.28, 0.10, 0.03",
"hvac_perf_data_heating_max_speed_capacities": "0.99, 0.68, 0.55",
"hvac_perf_data_cooling_min_speed_capacities": "0.33, 0.37",
"hvac_perf_data_cooling_max_speed_capacities": "1.0, 1.13"
},
"sample_files/base-hvac-air-to-air-heat-pump-var-speed-detailed-performance-autosize.xml": {
"parent_hpxml": "sample_files/base-hvac-air-to-air-heat-pump-var-speed-detailed-performance-normalized-capacities.xml",
Expand Down Expand Up @@ -2332,15 +2332,15 @@
"sample_files/base-hvac-central-ac-only-var-speed-detailed-performance.xml": {
"parent_hpxml": "sample_files/base-hvac-central-ac-only-var-speed.xml",
"cooling_system_cooling_compressor_type": "variable speed",
"cooling_system_cooling_efficiency": 17.25,
"cooling_system_cooling_efficiency": 17.5,
"cooling_system_cooling_capacity": 36000,
"hvac_perf_data_capacity_type": "Absolute capacities",
"hvac_perf_data_cooling_outdoor_temperatures": "95.0, 82.0",
"hvac_perf_data_cooling_min_speed_capacities": "11700, 13200",
"hvac_perf_data_cooling_max_speed_capacities": "36000, 40000",
"hvac_perf_data_cooling_min_speed_cops": "4.57, 6.34",
"hvac_perf_data_cooling_max_speed_cops": "2.71, 3.53",
"additional_properties": "HeatPump=YORK HMH7|HeatPumpAHRICert#=208613158"
"hvac_perf_data_cooling_min_speed_capacities": "11900, 13400",
"hvac_perf_data_cooling_max_speed_capacities": "36000, 40500",
"hvac_perf_data_cooling_min_speed_cops": "4.47, 6.33",
"hvac_perf_data_cooling_max_speed_cops": "2.64, 3.46",
"additional_properties": "HeatPump=YORK HMH7|HeatPumpAHRICert#=206921308"
},
"sample_files/base-hvac-central-ac-only-var-speed-detailed-performance-autosize.xml": {
"parent_hpxml": "sample_files/base-hvac-central-ac-only-var-speed-detailed-performance.xml",
Expand Down Expand Up @@ -2733,22 +2733,22 @@
"sample_files/base-hvac-mini-split-air-conditioner-only-ductless-detailed-performance.xml": {
"parent_hpxml": "sample_files/base-hvac-mini-split-air-conditioner-only-ductless.xml",
"cooling_system_cooling_compressor_type": "variable speed",
"cooling_system_cooling_efficiency": 21.5,
"cooling_system_cooling_efficiency": 17.0,
"cooling_system_cooling_capacity": 36000,
"hvac_perf_data_capacity_type": "Absolute capacities",
"hvac_perf_data_cooling_outdoor_temperatures": "95.0, 82.0",
"hvac_perf_data_cooling_min_speed_capacities": "10372, 19456",
"hvac_perf_data_cooling_max_speed_capacities": "42653, 40093",
"hvac_perf_data_cooling_min_speed_cops": "4.05, 8.03",
"hvac_perf_data_cooling_max_speed_cops": "3.27, 5.52",
"additional_properties": "HeatPump=Bosch Climate 5000|HeatPumpAHRICert#=203991186"
"hvac_perf_data_cooling_min_speed_capacities": "9100, 9900",
"hvac_perf_data_cooling_max_speed_capacities": "36400, 43300",
"hvac_perf_data_cooling_min_speed_cops": "3.76, 4.61",
"hvac_perf_data_cooling_max_speed_cops": "2.45, 3.51",
"additional_properties": "HeatPump=Midea|HeatPumpAHRICert#=207683365"
},
"sample_files/base-hvac-mini-split-air-conditioner-only-ductless-detailed-performance-autosize.xml": {
"parent_hpxml": "sample_files/base-hvac-mini-split-air-conditioner-only-ductless-detailed-performance.xml",
"cooling_system_cooling_capacity": null,
"hvac_perf_data_capacity_type": "Normalized capacity fractions",
"hvac_perf_data_cooling_min_speed_capacities": "0.255, 0.28",
"hvac_perf_data_cooling_max_speed_capacities": "1.0, 1.033"
"hvac_perf_data_cooling_min_speed_capacities": "0.25, 0.28",
"hvac_perf_data_cooling_max_speed_capacities": "1.01, 1.20"
},
"sample_files/base-hvac-mini-split-heat-pump-ducted.xml": {
"parent_hpxml": "sample_files/base.xml",
Expand Down Expand Up @@ -2851,30 +2851,30 @@
"heat_pump_cooling_compressor_type": "variable speed",
"heat_pump_heating_capacity_retention_fraction": null,
"heat_pump_heating_capacity_retention_temp": null,
"heat_pump_cooling_efficiency": 21.5,
"heat_pump_heating_efficiency": 10.5,
"heat_pump_cooling_efficiency": 17.0,
"heat_pump_heating_efficiency": 10.0,
"hvac_perf_data_capacity_type": "Absolute capacities",
"hvac_perf_data_heating_outdoor_temperatures": "47.0, 17.0, 5.0",
"hvac_perf_data_heating_min_speed_capacities": "12143, 7414, 8130",
"hvac_perf_data_heating_max_speed_capacities": "56499, 43387, 36037",
"hvac_perf_data_heating_min_speed_cops": "4.81, 1.96, 1.71",
"hvac_perf_data_heating_max_speed_cops": "3.17, 2.31, 1.96",
"hvac_perf_data_heating_outdoor_temperatures": "47.0, 17.0, 5.0, -13.0",
"hvac_perf_data_heating_min_speed_capacities": "11400, 5600, 3600, 2600",
"hvac_perf_data_heating_max_speed_capacities": "46500, 25000, 22000, 16000",
"hvac_perf_data_heating_min_speed_cops": "3.48, 2.78, 1.88, 1.52",
"hvac_perf_data_heating_max_speed_cops": "2.75, 2.11, 1.8, 1.31",
"hvac_perf_data_cooling_outdoor_temperatures": "95.0, 82.0",
"hvac_perf_data_cooling_min_speed_capacities": "10372, 19456",
"hvac_perf_data_cooling_max_speed_capacities": "42653, 40093",
"hvac_perf_data_cooling_min_speed_cops": "4.05, 8.03",
"hvac_perf_data_cooling_max_speed_cops": "3.27, 5.52",
"additional_properties": "HeatPump=Bosch Climate 5000|HeatPumpAHRICert#=203991186"
"hvac_perf_data_cooling_min_speed_capacities": "9100, 9900",
"hvac_perf_data_cooling_max_speed_capacities": "36400, 43300",
"hvac_perf_data_cooling_min_speed_cops": "3.76, 4.61",
"hvac_perf_data_cooling_max_speed_cops": "2.45, 3.51",
"additional_properties": "HeatPump=Midea|HeatPumpAHRICert#=207683365"
},
"sample_files/base-hvac-mini-split-heat-pump-ductless-detailed-performance-autosize.xml": {
"parent_hpxml": "sample_files/base-hvac-mini-split-heat-pump-ductless-detailed-performance.xml",
"heat_pump_heating_capacity": null,
"heat_pump_cooling_capacity": null,
"hvac_perf_data_capacity_type": "Normalized capacity fractions",
"hvac_perf_data_heating_min_speed_capacities": "0.34, 0.21, 0.23",
"hvac_perf_data_heating_max_speed_capacities": "1.57, 1.21, 1.00",
"hvac_perf_data_cooling_min_speed_capacities": "0.29, 0.54",
"hvac_perf_data_cooling_max_speed_capacities": "1.18, 1.11"
"hvac_perf_data_heating_min_speed_capacities": "0.30, 0.15, 0.09, 0.07",
"hvac_perf_data_heating_max_speed_capacities": "1.22, 0.66, 0.58, 0.42",
"hvac_perf_data_cooling_min_speed_capacities": "0.25, 0.28",
"hvac_perf_data_cooling_max_speed_capacities": "1.01, 1.20"
},
"sample_files/base-hvac-mini-split-heat-pump-ductless-heating-capacity-17f.xml": {
"parent_hpxml": "sample_files/base-hvac-mini-split-heat-pump-ductless.xml"
Expand Down
38 changes: 19 additions & 19 deletions ...w/sample_files/base-hvac-air-to-air-heat-pump-var-speed-detailed-performance-autosize.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
<extension>
<AdditionalProperties>
<HeatPump>YORK HMH7</HeatPump>
<HeatPumpAHRICert>208613158</HeatPumpAHRICert>
<HeatPumpAHRICert>206921308</HeatPumpAHRICert>
</AdditionalProperties>
</extension>
</BuildingSummary>
Expand Down Expand Up @@ -344,20 +344,20 @@
<FractionCoolLoadServed>1.0</FractionCoolLoadServed>
<AnnualCoolingEfficiency>
<Units>SEER</Units>
<Value>17.25</Value>
<Value>17.5</Value>
</AnnualCoolingEfficiency>
<AnnualHeatingEfficiency>
<Units>HSPF</Units>
<Value>10.0</Value>
<Value>9.5</Value>
</AnnualHeatingEfficiency>
<CoolingDetailedPerformanceData>
<PerformanceDataPoint>
<OutdoorTemperature>95.0</OutdoorTemperature>
<CapacityFractionOfNominal>0.325</CapacityFractionOfNominal>
<CapacityFractionOfNominal>0.33</CapacityFractionOfNominal>
<CapacityDescription>minimum</CapacityDescription>
<Efficiency>
<Units>COP</Units>
<Value>4.57</Value>
<Value>4.47</Value>
</Efficiency>
</PerformanceDataPoint>
<PerformanceDataPoint>
Expand All @@ -366,7 +366,7 @@
<CapacityDescription>maximum</CapacityDescription>
<Efficiency>
<Units>COP</Units>
<Value>2.71</Value>
<Value>2.64</Value>
</Efficiency>
</PerformanceDataPoint>
<PerformanceDataPoint>
Expand All @@ -375,16 +375,16 @@
<CapacityDescription>minimum</CapacityDescription>
<Efficiency>
<Units>COP</Units>
<Value>6.34</Value>
<Value>6.33</Value>
</Efficiency>
</PerformanceDataPoint>
<PerformanceDataPoint>
<OutdoorTemperature>82.0</OutdoorTemperature>
<CapacityFractionOfNominal>1.11</CapacityFractionOfNominal>
<CapacityFractionOfNominal>1.13</CapacityFractionOfNominal>
<CapacityDescription>maximum</CapacityDescription>
<Efficiency>
<Units>COP</Units>
<Value>3.53</Value>
<Value>3.46</Value>
</Efficiency>
</PerformanceDataPoint>
</CoolingDetailedPerformanceData>
Expand All @@ -395,43 +395,43 @@
<CapacityDescription>minimum</CapacityDescription>
<Efficiency>
<Units>COP</Units>
<Value>4.73</Value>
<Value>4.68</Value>
</Efficiency>
</PerformanceDataPoint>
<PerformanceDataPoint>
<OutdoorTemperature>47.0</OutdoorTemperature>
<CapacityFractionOfNominal>1.0</CapacityFractionOfNominal>
<CapacityFractionOfNominal>0.99</CapacityFractionOfNominal>
<CapacityDescription>maximum</CapacityDescription>
<Efficiency>
<Units>COP</Units>
<Value>3.44</Value>
<Value>3.4</Value>
</Efficiency>
</PerformanceDataPoint>
<PerformanceDataPoint>
<OutdoorTemperature>17.0</OutdoorTemperature>
<CapacityFractionOfNominal>0.12</CapacityFractionOfNominal>
<CapacityFractionOfNominal>0.1</CapacityFractionOfNominal>
<CapacityDescription>minimum</CapacityDescription>
<Efficiency>
<Units>COP</Units>
<Value>1.84</Value>
<Value>1.57</Value>
</Efficiency>
</PerformanceDataPoint>
<PerformanceDataPoint>
<OutdoorTemperature>17.0</OutdoorTemperature>
<CapacityFractionOfNominal>0.69</CapacityFractionOfNominal>
<CapacityFractionOfNominal>0.68</CapacityFractionOfNominal>
<CapacityDescription>maximum</CapacityDescription>
<Efficiency>
<Units>COP</Units>
<Value>2.66</Value>
<Value>2.58</Value>
</Efficiency>
</PerformanceDataPoint>
<PerformanceDataPoint>
<OutdoorTemperature>5.0</OutdoorTemperature>
<CapacityFractionOfNominal>0.05</CapacityFractionOfNominal>
<CapacityFractionOfNominal>0.03</CapacityFractionOfNominal>
<CapacityDescription>minimum</CapacityDescription>
<Efficiency>
<Units>COP</Units>
<Value>0.81</Value>
<Value>0.47</Value>
</Efficiency>
</PerformanceDataPoint>
<PerformanceDataPoint>
Expand All @@ -440,7 +440,7 @@
<CapacityDescription>maximum</CapacityDescription>
<Efficiency>
<Units>COP</Units>
<Value>2.28</Value>
<Value>2.63</Value>
</Efficiency>
</PerformanceDataPoint>
</HeatingDetailedPerformanceData>
Expand Down
Loading

0 comments on commit b0cf68b

Please sign in to comment.