Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Error with time series Normalization on Sienna Export #90

Closed
ktehranchi opened this issue Nov 22, 2024 · 1 comment
Closed

bug: Error with time series Normalization on Sienna Export #90

ktehranchi opened this issue Nov 22, 2024 · 1 comment

Comments

@ktehranchi
Copy link
Collaborator

ktehranchi commented Nov 22, 2024

Describe the bug
Error on Sienna TS export: We use a Normalization Factor: 'Max' for timeseries pointers, then multiply them by max_active_power through ("scaling_factor_multiplier": "get_max_active_power").

This will lead to errors with Timeseries which do not contain 100% capacity factor values.

Example:
TS value: 80
Max value of TS array: 90
Max active power: 100

TS value loaded to PSY: 80 / 90 * 100 = 88

@pesap Would be good to get your thoughts on this, since we'll have to align how we export data with how we parse data from either plexos/reeds.

@pesap
Copy link
Collaborator

pesap commented Jan 17, 2025

We are removing all the scaling factor based on this. See #102

@pesap pesap closed this as completed Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants