Update mhk equation docstrings #1217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are the inputs / outputs up to date for the docstrings, e.g. me_array_cable_length_doc? I see 5 inputs in the doc but 10 in the function itself |
dguittet
reviewed
Oct 14, 2024
ssc/ssc_equations.h
Outdated
| {"me_array_cable_length", me_array_cable_length, | ||
| "Marine Energy", me_array_cable_length_doc, | ||
| {"me_array_cable_length", me_array_cable_length, | ||
| "MhkWave", me_array_cable_length_doc, |
There was a problem hiding this comment.
I think this should be attached to the MhkCost module, since the outputs of these equations are inputs to MhkCost, not MhkWave or MhkTidal. Thoughts?
mjprilliman
changed the title
|
Updated equation docstrings. No longer linking mhk equations to PySAM modules at this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Closes #1197
-See #1198 for discussion from patch