-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check NOCT model implementation #917
Comments
Perhaps the same thing on the pvlib side: pvlib/pvlib-python#1462 |
Any thoughts or new insights on this? |
Hi Anton, Thanks for bringing this back to attention. I had previously investigated this issue and compared SAM's implementation with the referenced equations in Duffie and Beckman 3rd edition. At that time I felt that SAM's implementation was consistent with Duffie and Beckman, but there was a bit of uncertainty in how to define the irradiance term. I did mean to follow up with you at that time but this issue got lost in the shuffle a bit. I will take a look at this again soon and compile my notes. Perhaps we could find a time to discuss this further in early January 2024? |
@adriesse @kandersolar I believe the second paragraph of this page (Duffie and Beckman 4th edition) is the relevant discussion point here. The tau-alpha term is corrected by the effective irradiance to represent the absorbed irradiance rather than the incident irradiance, and the incident irradiance is used for the G_T term. Certainly open to discussing a different interpretation of that equation and making a change to the code, but I believe that was the basis for the current implementation. |
Here's the relevant comment from my paper for convenience.
In D&B, (τα) is constant, right? |
Correct, it is an assumed constant for the system energy balance. For the NOCT balance, going from 23.3.2 to 23.3.3 (which is the ratio of 23.3.1 to 23.3.2 changes τα * G_T,NOCT to just G_NOCT, which is just a constant 800 W/m2 regardless of τα, so it's not immediately clear to me how the τα for the NOCT energy balance factors into things. |
I'm not sure what to suggest. Maybe work through some cases by hand or in Excel (gasp)? |
Just passing by... :) |
Hi Anton, thanks for bringing this back to attention. I can hopefully take a look at this issue again in October. The relevant code is here: Lines 216 to 277 in 274560a
If you have a suggested edit of the equation based on how it is written here, that would be much appreciated. |
Describe the bug
A question on the implementation of the NOCT cell temeprature model equation used with the CEC performance models was presented in https://www.researchgate.net/publication/361463601_PV_Module_Operating_Temperature_Model_Equivalence_and_Parameter_Translation. Evaluate the implementation of the model based on the definitions presented in the SAM technical reference, the DeSoto model paper, and the Duffie and Beckman textbook. Confirm whether the POA irradiance used in the model should be before or after reflection effects, and consider how this definition effects the efficiency and absorptance-transmittance product variables used in the model.
The text was updated successfully, but these errors were encountered: