Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2][_commonspeckle] SAXS.py not strictly for XPCS or speckles #41

Open
ambarb opened this issue Oct 8, 2020 · 1 comment
Open

[v2][_commonspeckle] SAXS.py not strictly for XPCS or speckles #41

ambarb opened this issue Oct 8, 2020 · 1 comment
Labels
_commonspeckle part of V2, but strictly related to a common repo (speckle + maybe scattering) discussion Q-space V2 required to move towards share XPCS/speckle analysis for CHX/CSX

Comments

@ambarb
Copy link
Collaborator

ambarb commented Oct 8, 2020

This is for static SAXS analysis as noted by module author. Seems good to keep this in common, but if we stick it in an XPCS repo, I am not sure that it would be under utilized.

Also @danielballan mentioned something about a common scattering repo in previous meetings so I am also asking in this context. We could decide on a two-phase plan regarding this.

  1 """
  2 Sep 10 Developed by Y.G.@CHX 
  3 [email protected]
  4 This module is for the static SAXS analysis, such as fit form factor
  5 """

@ambarb ambarb added V2 required to move towards share XPCS/speckle analysis for CHX/CSX _commonspeckle part of V2, but strictly related to a common repo (speckle + maybe scattering) discussion labels Oct 8, 2020
@ambarb
Copy link
Collaborator Author

ambarb commented Oct 8, 2020

Note that the papermill report does indicate each roi's q in Å ^-1 so this module is part of the results pipeline.

  • Explicitly document how SAXS.py is integrated into results
  • Determine if SAXS.py stays permanently in _commonspeckle or independent scattering repo

@ambarb ambarb added the Q-space label Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_commonspeckle part of V2, but strictly related to a common repo (speckle + maybe scattering) discussion Q-space V2 required to move towards share XPCS/speckle analysis for CHX/CSX
Projects
None yet
Development

No branches or pull requests

1 participant