Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move specific functions from V3 chx_generic_fn to specific modules #58

Open
ambarb opened this issue Feb 8, 2021 · 0 comments
Open
Labels
V3 lower priority, could be before V2 or after V2

Comments

@ambarb
Copy link
Collaborator

ambarb commented Feb 8, 2021

If we do this, they become easier to find for a common library and are seen to by a wider audience. We should keep the docstring attributes to @yugangzhang.

Stopped for now because this is starting to seem like a V3 problem.

Table of functions and where they can go

Function Move to Comments
sgolay2d _commonspeckle. or skbeam.core.utils
apply_mask _commonspeckle or skbeam.core.roi
get_max_countc _commonspeckle or skbeam.core.roi roi has some of these functions, but for frames. same function is in chx_speckle*

high level plotting functions that may be generally useful to set aside

show_img

@ambarb ambarb changed the title move specific functions from V2 chi_generic_fn to specific modules move specific functions from V3 chi_generic_fn to specific modules Feb 8, 2021
@ambarb ambarb changed the title move specific functions from V3 chi_generic_fn to specific modules move specific functions from V3 chx_generic_fn to specific modules Feb 8, 2021
@ambarb ambarb added the V3 lower priority, could be before V2 or after V2 label Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V3 lower priority, could be before V2 or after V2
Projects
None yet
Development

No branches or pull requests

1 participant