Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to callback_url field to ensure it accepts port number #129

Open
djanderson opened this issue Sep 28, 2018 · 1 comment
Open

Add test to callback_url field to ensure it accepts port number #129

djanderson opened this issue Sep 28, 2018 · 1 comment

Comments

@djanderson
Copy link
Contributor

Currently this implementation of callback_url does accept a port number (and forwards to the correct port, tested by nc -l 10000 and then sending to that. Note that 127.0.0.1 and localhost do not work since they have different meanings from inside the docker container but using my computer's actual IP, it forwarded to the correct port).

It should generally be acceptable, but specifically for a sample streaming action the receive application will most likely not be running on :80.

@djanderson
Copy link
Contributor Author

Also when passing a raw ip to callback_url (e.g., 10.0.0.20:8000) the input parser rejects with a rather unuseful error "Enter a valid URL". The problem is it needs http or such in front, so either a hint in the error message or an example URL would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant