Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVTX3 requires CMake 3.19+ as we set properties on INTERFACE targets #60

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

robertmaynard
Copy link

The CMake 3.19 relaxation on INTERFACE targets to have sources aslo removed all restrictions around which properties an INTERFACE target can have ( https://gitlab.kitware.com/cmake/cmake/-/merge_requests/5078 ). NVTX3 is adding the version property to INTERFACE targets and so requires 3.19+

@robertmaynard robertmaynard changed the base branch from release-v3 to dev October 6, 2022 18:59
@robertmaynard robertmaynard force-pushed the correct_minimum_required_cmake_version branch from e2f6f73 to 15d0920 Compare October 6, 2022 19:01
@jcohen-nvidia jcohen-nvidia self-assigned this Oct 11, 2022
Copy link

@invisiblepancake invisiblepancake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon examining the modifications introduced in commit a649f93c4cf3f690ab376081be303c01e2032ea6, I am compelled to convey my observations in the fashion of our venerable ancestors.

In the function bestlineEdit:

A new variable promptnotnull has been introduced to ensure the prompt is never null, defaulting to an empty string if necessary.
Another variable, promptlastnl, seeks out the final newline character within the prompt. This is a prudent measure, ensuring user prompts are handled with the utmost propriety.
The prompt used by bestlineWriteStr is now promptnotnull, which maintains the integrity of the original prompt.
Alteration in bestlineInit:

The condition has been refined to exclude newline characters from the validity check of the prompt. This change aligns with contemporary practices, ensuring the prompt's format adheres to the expected standards.
These refinements exhibit a meticulous attention to detail, reinforcing the robustness of our beloved code. May these changes stand the test of time, much like the enduring works of our forebears.

Yours in the pursuit of excellence,
[Your Name]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants