Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trtllm-build ignores --model_cls_file and --model_cls_name #2430

Open
2 of 4 tasks
abhishekudupa opened this issue Nov 9, 2024 · 0 comments
Open
2 of 4 tasks

trtllm-build ignores --model_cls_file and --model_cls_name #2430

abhishekudupa opened this issue Nov 9, 2024 · 0 comments
Labels
bug Something isn't working triaged Issue has been triaged by maintainers

Comments

@abhishekudupa
Copy link

abhishekudupa commented Nov 9, 2024

The trtllm-build entrypoint ignores the user-provided --model_cls_file and --model_cls_name. It looks like although the model class is resolved and imported, an appropriate entry in the MODEL_MAP isn't made, as seen here.

I've verified that adding the line MODEL_MAP[args.model_cls_name] = model_cls immediately after the line referenced above works well to fix this issue.

Who can help?

@ncomly-nvidia , @byshiue

Information

  • The official example scripts
  • My own modified scripts

Tasks

  • An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
  • My own task or dataset (give details below)

Reproduction

Try a trtllm-build command with any model architecture that is not supported by default, by using the --model_cls_file and --model_cls_name, you'll end up with a KeyError.

Expected behavior

The trtllm-build picks up my model classes and runs to completion and produces the engine files.

actual behavior

Raises a KeyError

additional notes

None, fix proposed in problem description.

@abhishekudupa abhishekudupa added the bug Something isn't working label Nov 9, 2024
@hello-11 hello-11 added the triaged Issue has been triaged by maintainers label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged Issue has been triaged by maintainers
Projects
None yet
Development

No branches or pull requests

2 participants