Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion failed: noRepeatNgramSize.value() > 0 #2442

Open
2 of 4 tasks
krishnanpooja opened this issue Nov 13, 2024 · 1 comment
Open
2 of 4 tasks

Assertion failed: noRepeatNgramSize.value() > 0 #2442

krishnanpooja opened this issue Nov 13, 2024 · 1 comment
Assignees
Labels
bug Something isn't working triaged Issue has been triaged by maintainers

Comments

@krishnanpooja
Copy link

System Info

GPU-A100,
TensorRT-LLM version = tensorrt_llm-0.13.0.dev2024090300
Ubuntu machine.

Who can help?

hi @ncomly-nvidia , @byshiue ,

I want to set the 'no_repeat_ngram_size'=0 for mistral model. But I get the following assertion error:

RuntimeError: [TensorRT-LLM][ERROR] Assertion failed: noRepeatNgramSize.value() > 0 (/home/jenkins/agent/workspace/LLM/main/L0_PostMerge/llm/cpp/tensorrt_llm/executor/samplingConfig.cpp:332)

As per the documentation the default value is 1 << 30, is there way to set the value to 0? If not, can this feature be added?

Information

  • The official example scripts
  • My own modified scripts

Tasks

  • An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
  • My own task or dataset (give details below)

Reproduction

Setting no_repear_ngram_size=0 under SamplingParams for mistral model.

Expected behavior

User should be allowed to allowed to set this value to 0.

actual behavior

Getting assertion error.

additional notes

We want to set it to 0 like we do for pytorch-eager used for inference.

@krishnanpooja krishnanpooja added the bug Something isn't working label Nov 13, 2024
@hello-11 hello-11 added the triaged Issue has been triaged by maintainers label Nov 14, 2024
@byshiue byshiue self-assigned this Nov 14, 2024
@byshiue
Copy link
Collaborator

byshiue commented Nov 14, 2024

Could you explain your motivation to setting it as 0 instead of 1 << 30? 1 << 30 should work equivalent to 0 and it is more friend to our kernel implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged Issue has been triaged by maintainers
Projects
None yet
Development

No branches or pull requests

3 participants