Add StormCast model #164
Merged
Add StormCast model #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Harrington <[email protected]>
Signed-off-by: Peter Harrington <[email protected]>
Signed-off-by: Peter Harrington <[email protected]>
Signed-off-by: Peter Harrington <[email protected]>
Signed-off-by: Peter Harrington <[email protected]>
Signed-off-by: Peter Harrington <[email protected]>
|
/blossom-ci |
…/earth2studio into pharring/stormcast-tests
Signed-off-by: Peter Harrington <[email protected]>
Signed-off-by: Peter Harrington <[email protected]>
Signed-off-by: Peter Harrington <[email protected]>
|
/blossom-ci |
|
Looks really good, just the few minor comments. |
NickGeneva
reviewed
Dec 19, 2024
NickGeneva
reviewed
Dec 19, 2024
|
Oh also add this to the RST file: So it gets build into the docs 👍 |
NickGeneva
approved these changes
Dec 19, 2024
Signed-off-by: Peter Harrington <[email protected]>
Signed-off-by: Peter Harrington <[email protected]>
|
/blossom-ci |
dallasfoster
approved these changes
Dec 19, 2024
|
/blossom-ci |
1 similar comment
|
/blossom-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earth2Studio Pull Request
Description
Adds the StormCast model as a prognostic model. Due to the use of curvilinear coordinates in HRRR data (lambert conformal projection) and conditioning data this incurs some minor changes elsewhere; mainly the ability to perform xarray interpolation to a desired set of coordinates has been added to
fetch_data.Checklist
Dependencies
The StormCast model depends on newly added material in modulus which has not yet been released, so the toml needs an update.