Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Short flags for --platform does not work #1497

Open
parthosa opened this issue Jan 10, 2025 · 0 comments · May be fixed by #1498
Open

[BUG] Short flags for --platform does not work #1497

parthosa opened this issue Jan 10, 2025 · 0 comments · May be fixed by #1498
Assignees
@parthosa
Labels
? - Needs Triage bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python)

Comments

@parthosa
Copy link
Collaborator

Description

In #1472, the --platform argument was made a required parameter in Fire. In our tests, it was found that the short flag -p for platform is no longer functioning.

Upon investigation, it seems that Fire does not support short flags for required arguments.

Proposed Solution
We should make the platform argument optional in Fire. This change will ensure compatibility with the -p flag. The platform argument will still be validated internally to ensure its requirement is enforced.
@parthosa parthosa added ? - Needs Triage bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python) labels Jan 10, 2025
@parthosa parthosa self-assigned this Jan 10, 2025
@parthosa parthosa linked a pull request Jan 10, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthosa parthosa

Labels
? - Needs Triage bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Follow Up: Make '--platform' argument mandatory in CLI (#1473)" parthosa/spark-rapids-tools
1 participant
@parthosa