Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Update core tools to allow cross-build between 2.12 and 2.13 #1507

Closed
Tracked by #1158
amahussein opened this issue Jan 22, 2025 · 0 comments · Fixed by #1510
Closed
Tracked by #1158

[FEA] Update core tools to allow cross-build between 2.12 and 2.13 #1507

amahussein opened this issue Jan 22, 2025 · 0 comments · Fixed by #1510
Labels
core_tools Scope the core module (scala) feature request New feature or request

Comments

@amahussein
Copy link
Collaborator

amahussein commented Jan 22, 2025 •
edited
Loading

Is your feature request related to a problem? Please describe.

Currently, tools only work on scala2.12.
This issue is triggered to do an initial cleanup to the code to allow cross-compilation between scala-2.12 and scala-2.13
This will make supporting Spark-4 feasible when it is released.

This requires basically to update core/scalastyle-config.xml to enforce some rules.
@amahussein amahussein added ? - Needs Triage core_tools Scope the core module (scala) feature request New feature or request labels Jan 22, 2025
@amahussein amahussein mentioned this issue Jan 22, 2025
Closed
amahussein added a commit to amahussein/spark-rapids-tools that referenced this issue Jan 22, 2025
@amahussein
Update core tools rules to allow cross-build between 2.12 and 2.13
3cad7e1 
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>

Fixes NVIDIA#1507

Improve source code to allow cross-build between scala-2.12 and
scala2.13
@amahussein amahussein mentioned this issue Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core_tools Scope the core module (scala) feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update core tools rules to allow cross-build between 2.12 and 2.13 amahussein/spark-rapids-tools
1 participant
@amahussein