Skip to content

Commit

Permalink
Migrate to jupyterlab. Fix scene.preview() issue (#145)
Browse files Browse the repository at this point in the history
scene.preview breaks due to dependency issues. Localized issues:
1. Need to use jupyter lab
2. jupyterlab-widgets needs to be 3.0.5
Made changes to DOCKERFILE, requirements.txt and setup.cfg
Docker image is tested to work.

Signed-off-by: Raghav Subbaraman <[email protected]>
  • Loading branch information
rsubbaraman authored Jul 11, 2023
1 parent 0565aa8 commit 08b1bd2
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
4 changes: 2 additions & 2 deletions DOCKERFILE
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ COPY . /tmp/
WORKDIR /tmp/
RUN make install
RUN apt-get install llvm -y
RUN pip install --upgrade jupyter
RUN pip install --upgrade ipykernel
RUN pip install --upgrade jupyterlab
RUN rm -R /tf/* && cp /tmp/examples/* /tf
RUN rm -R /tmp
RUN chmod 777 -R /tf
WORKDIR /tf
CMD ["jupyter", "notebook", "--port=8888", "--no-browser", "--NotebookApp.token=''", "--ip=0.0.0.0", "--allow-root", "--NotebookApp.allow_origin='*'"]
CMD ["jupyter", "lab", "--port=8888", "--no-browser", "--NotebookApp.token=''", "--ip=0.0.0.0", "--allow-root", "--NotebookApp.allow_origin='*'"]
1 change: 1 addition & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ mitsuba >= 3.2.0
pythreejs >= 2.4.2
ipywidgets >= 8.0.4
ipydatawidgets == 4.3.2
jupyterlab-widgets == 3.0.5
1 change: 1 addition & 0 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ install_requires =
pythreejs >= 2.4.2
ipywidgets >= 8.0.4
ipydatawidgets == 4.3.2
jupyterlab-widgets == 3.0.5

[options.package_data]
* = *.csv, *.npy, *.json, *.xml, *.ply
Expand Down

0 comments on commit 08b1bd2

Please sign in to comment.