diff --git a/.github/workflows/production.yml b/.github/workflows/production.yml index 4594723..cd41490 100644 --- a/.github/workflows/production.yml +++ b/.github/workflows/production.yml @@ -11,6 +11,8 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 + - name: 'Install Heroku CLI' + run: curl https://cli-assets.heroku.com/install.sh | sh - name: Deploy to Heroku uses: akhileshns/heroku-deploy@v3.13.15 with: diff --git a/.github/workflows/qa.yml b/.github/workflows/qa.yml index 0e4e358..293a0de 100644 --- a/.github/workflows/qa.yml +++ b/.github/workflows/qa.yml @@ -11,6 +11,8 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 + - name: 'Install Heroku CLI' + run: curl https://cli-assets.heroku.com/install.sh | sh - name: Deploy to Heroku uses: akhileshns/heroku-deploy@v3.13.15 with: diff --git a/.github/workflows/staging.yml b/.github/workflows/staging.yml index 0785803..0eba220 100644 --- a/.github/workflows/staging.yml +++ b/.github/workflows/staging.yml @@ -14,6 +14,8 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 + - name: 'Install Heroku CLI' + run: curl https://cli-assets.heroku.com/install.sh | sh - name: Deploy to Heroku uses: akhileshns/heroku-deploy@v3.13.15 with: diff --git a/app/utils/analytics.js b/app/utils/analytics.js index 082f570..c4553ae 100644 --- a/app/utils/analytics.js +++ b/app/utils/analytics.js @@ -18,13 +18,13 @@ export function analytics(eventData) { } export function analyticsTrackFilterByDistrictToggle(expandedIndex) { - if(expandedIndex===0) { + if (expandedIndex === 0) { analytics({ category: "Accordion", action: "Toggle Filter By District Accordion", name: "Open", }); - } else if(expandedIndex===-1) { + } else if (expandedIndex === -1) { analytics({ category: "Accordion", action: "Toggle Filter By District Accordion", @@ -40,13 +40,13 @@ export function analyticsTrackFilterByDistrictToggle(expandedIndex) { } export function analyticsTrackSelectedDistrictToggle(expandedIndex) { - if(expandedIndex===0) { + if (expandedIndex === 0) { analytics({ category: "Accordion", action: "Toggle Selected District Accordion", name: "Open", }); - } else if(expandedIndex===-1) { + } else if (expandedIndex === -1) { analytics({ category: "Accordion", action: "Toggle Selected District Accordion", @@ -62,13 +62,13 @@ export function analyticsTrackSelectedDistrictToggle(expandedIndex) { } export function analyticsWelcomePanelToggle(expandedIndex) { - if(expandedIndex===0) { + if (expandedIndex === 0) { analytics({ category: "Accordion", action: "Toggle Welcome Panel Accordion", name: "Open", }); - } else if(expandedIndex===-1) { + } else if (expandedIndex === -1) { analytics({ category: "Accordion", action: "Toggle Welcome Panel Accordion", diff --git a/app/utils/utils.ts b/app/utils/utils.ts index ed8a61f..74cb7e9 100644 --- a/app/utils/utils.ts +++ b/app/utils/utils.ts @@ -25,7 +25,7 @@ export function setNewSearchParams( const newSearchParams = new URLSearchParams(searchParams); for (const [key, value] of Object.entries(changes)) { - if (value === (undefined || null)) { + if (value === undefined || value === null) { newSearchParams.delete(key); continue; }