Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback for Confirmation Email Template #92

Open
jessicashanshanhuang opened this issue Dec 19, 2024 · 7 comments
Open

Feedback for Confirmation Email Template #92

jessicashanshanhuang opened this issue Dec 19, 2024 · 7 comments

Comments

@jessicashanshanhuang
Copy link
Contributor

jessicashanshanhuang commented Dec 19, 2024

@TylerMatteo QA feedback for when a user sees an email to confirm their subscriptions.

@jessicashanshanhuang
Copy link
Contributor Author

For the email header:

The Zoning Application Portal text in should be around 1.3125 rem

Image

For the information card:

We might want to try to have the text shifted more towards the center or make the background box smaller since there is a decent amount of negative space on the right. Though we should consider how it looks as well if there are multiple lines of text when a user subscribes to multiple CDs versus one.

Image

@pratishta
Copy link

@jessicashanshanhuang Tried to adjust the text to be more center aligned. Following is how it looks on desktop and mobile respectively.
Image
Image

Question

Does this seem enough? Adjusting the background box or the text more to cover the negative space makes the mobile views more wonky, see below examples.
Image
Image

@jessicashanshanhuang
Copy link
Contributor Author

Does this seem enough? Adjusting the background box or the text more to cover the negative space makes the mobile views more wonky, see below examples.

@pratishta hmm, I do see how it does look wonky on mobile. The current changes seems good for centering without distorting the other views! Also I noticed the hex color for the text seem to have changed in your version, was that an intentional change?

@pratishta
Copy link

Also I noticed the hex color for the text seem to have changed in your version, was that an intentional change?

@jessicashanshanhuang No, these screenshots are from the Sendgrid dynamic template preview. A screenshot from my Gmail inbox looks like the following
Image

@pratishta
Copy link

@jessicashanshanhuang Regarding changing the font size, we currently calculate the font size of 'Zoning Application Portal' in the header based on the viewport height and width. Changing it to 1.3125 rem doesn't change it very much on desktop (though it is bigger) but it looks like this in mobile:
Image

Currently it looks like this.
Image

Let me know if you'd still like to go ahead with the font changes.

@jessicashanshanhuang
Copy link
Contributor Author

Hey @pratishta 👋

The body text looks good, I was wondering if we could adjust the header font size to 0.875 rem? Trying to see if we can make the header look less compact.

@pratishta
Copy link

@jessicashanshanhuang By header, do you mean the 'Department of City Planning' part?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants