Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build is failing with VS2022 #16

Open
pixtur opened this issue Oct 28, 2023 · 3 comments
Open

Build is failing with VS2022 #16

pixtur opened this issue Oct 28, 2023 · 3 comments

Comments

@pixtur
Copy link

pixtur commented Oct 28, 2023

Thanks a lot of this awesome project! It really helped me a lot setting up a basic PBR rendering pipeline.

Sadly I wasn't able to build the executable with VS2022,

I get a list of compile errors like...

Severity	Code	Description	Project	File	Line	Suppression State
Error	C2102	'&' requires l-value	PBR	C:\Users\pixtur\dev\__research\PBR\src\d3d12.cpp	377	

I already installed Vulcan. Does this error indicate that I also need a special version of DX12?

I there by any chance a prebuilt windows executable available?

@cool-cola
Copy link

cool-cola commented Oct 28, 2023 via email

@PAMinerva
Copy link

PAMinerva commented Feb 5, 2024

  • add #include <stdexcept> to mesh.cpp

  • remove the /std:c++latest compiler option from PBR property pages -> Configuration Properties -> C/C++ -> Command Line -> Additional Options

  • change from $(ProjectDir) to ..\..\data in PBR property pages -> Configuration Properties -> Debugging -> Working Directory


ps. if you still get C2102 errors, try setting No in PBR property pages -> Configuration Properties -> C/C++ -> Language -> Conformance Mode

@cool-cola
Copy link

cool-cola commented Feb 5, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants