diff --git a/src/async_manager.hpp b/src/async_manager.hpp index 0c1daeec..79fa4741 100644 --- a/src/async_manager.hpp +++ b/src/async_manager.hpp @@ -80,7 +80,7 @@ class nervana::async_manager : public virtual nervana::async_manager_source> source, const std::string& name) - : m_source(source) + : m_source(std::move(source)) , m_state{async_state::idle} , m_name{name} { diff --git a/src/interface.cpp b/src/interface.cpp index 4d0af621..b8167449 100644 --- a/src/interface.cpp +++ b/src/interface.cpp @@ -26,6 +26,8 @@ using namespace nlohmann; int IGNORE_VALUE; +nervana::interface::config_info_interface::~config_info_interface() {}; + void json_configurable::verify_config( const std::string& location, const vector>& config, diff --git a/src/interface.hpp b/src/interface.hpp index f9518f1f..7f16405d 100644 --- a/src/interface.hpp +++ b/src/interface.hpp @@ -74,7 +74,7 @@ namespace nervana class nervana::interface::config_info_interface { public: - virtual ~config_info_interface() {} + virtual ~config_info_interface() = 0; virtual const std::string& name() const = 0; virtual void parse(nlohmann::json js) = 0; virtual bool required() const = 0;