Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: Broadcast Domain #303

Open
acch opened this issue Sep 30, 2024 · 3 comments · May be fixed by #333
Open

[New Resource]: Broadcast Domain #303

acch opened this issue Sep 30, 2024 · 3 comments · May be fixed by #333
Assignees
Labels
New Resource New Request for an ONTAP Resource
Milestone

Comments

@acch
Copy link

acch commented Sep 30, 2024

Description

Ability to create broadcast domains

Requested Resource(s) and/or Data Source(s)

  • netapp-ontap_broadcast_domain

Potential Terraform Configuration

// sample broadcast domain with required properties
resource "netapp-ontap_network_broadcast_domain" "example" {
  cx_profile_name = "cluster1"
  ipspace         = "Default"
  name            = "bd1"
  mtu             = "1500"
}

References

Would you like to implement a fix?

Yes

@carchi8py carchi8py added the New Resource New Request for an ONTAP Resource label Sep 30, 2024
@carchi8py carchi8py added this to the 2.1 milestone Sep 30, 2024
@acch
Copy link
Author

acch commented Nov 4, 2024

Do you have any objections with the proposed changes? If not, then I will go ahead and start working on a PR to implement the new broadcast_domain data source and resource...

@carchi8py
Copy link
Contributor

@acch yes go ahead and start working on this if you want. I'll go ahead and assign it to you.

For resources we try to have ACC test that run on a real system to test common error cases, (create/read/, update, and import).

If you run with these variable
https://github.com/NetApp/terraform-provider-netapp-ontap/blob/integration/main/internal/provider/networking/network_ip_interface_resource_alias_test.go#L60C1-L62C45

The pipeline will run the ACC test on a Vsim we have set up.

If you need something set up on that Vsim to run the ACC tests let me know.

@acch acch linked a pull request Nov 4, 2024 that will close this issue
@acch
Copy link
Author

acch commented Nov 7, 2024

I've prepared a PR to address this change: #333.

Please let me know if anything's missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Resource New Request for an ONTAP Resource
Projects
Status: 2.1
Development

Successfully merging a pull request may close this issue.

2 participants