Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PSUPCLPL-12244] HAProxy Maintenance Mode #435

Closed
wants to merge 15 commits into from
Closed

Conversation

pranavcracker
Copy link
Collaborator

@pranavcracker pranavcracker commented May 4, 2023

Description

Adding a new procedure to Kubemarine distribution for managing the maintenance mode for HAProxy load balancers.

Fixes # (issue)
#269

Solution

  • We are developing a new procedure which will help us to enable/disable maintenance mode by a single command as below

How to apply

Once the changes mentioned in this PR, we will have a automated procedure to enable or disable the maintenance mode on HAProxy load balancers.

  • Go to DVM --> Maintenance Job --> Build with parameters --> Select "haproxy_mntc" procedure from the drop down list --> provide the required argument (--mode enable/disable) --> Run the job
  • Manual step -
    Login to CLI and navigate to kubemarine directory --> run the following command
kubemarine haproxy_mntc --mode enable/disable

Test Cases

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

TestCase 1

Run haproxy_mntc procedure for the cluster where maintenance mode is not supported.
kubemarine haproxy_mntc --mode enable
ER- procedure should fail with error message "Skiping haproxy maintenance procedure as cluster is not supported for HAProxy Maintenance mode."

TestCase 2

Run haproxy_mntc procedure for the cluster where maintenance mode is supported.

  1. kubemarine haproxy_mntc --mode enable
  2. kubemarine haproxy_mntc --mode disable

ER- Procedure should succeed with enabling or disabling the maintenance mode on haproxy load balancer.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

@pranavcracker pranavcracker linked an issue May 4, 2023 that may be closed by this pull request
@pranavcracker pranavcracker marked this pull request as ready for review May 5, 2023 08:35
@koryaga koryaga requested review from ilia1243 and n549 May 5, 2023 08:35
@koryaga koryaga self-assigned this May 5, 2023
@koryaga koryaga marked this pull request as draft June 21, 2023 07:01
@koryaga
Copy link
Collaborator

koryaga commented Oct 8, 2023

decided to redesign

@koryaga koryaga closed this Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement procedure to switch haproxy mode
3 participants