From a557071ea6d0b57994b2a923da775934aa43b782 Mon Sep 17 00:00:00 2001
From: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
Date: Wed, 13 Nov 2024 15:40:41 -0800
Subject: [PATCH] Removes option to delete a signal definition (#5471)

* Removes delete dialog for signal definitions

* Removes delete endpoint and related service function

* removes delete test
---
 src/dispatch/signal/service.py                |  8 ---
 src/dispatch/signal/views.py                  | 17 ------
 .../dispatch/src/signal/DeleteDialog.vue      | 35 ------------
 .../static/dispatch/src/signal/Table.vue      |  8 +--
 tests/signal/test_signal_service.py           | 55 +++++++++----------
 5 files changed, 28 insertions(+), 95 deletions(-)
 delete mode 100644 src/dispatch/static/dispatch/src/signal/DeleteDialog.vue

diff --git a/src/dispatch/signal/service.py b/src/dispatch/signal/service.py
index 751201594093..eff71818ccef 100644
--- a/src/dispatch/signal/service.py
+++ b/src/dispatch/signal/service.py
@@ -536,14 +536,6 @@ def update(*, db_session: Session, signal: Signal, signal_in: SignalUpdate) -> S
     return signal
 
 
-def delete(*, db_session: Session, signal_id: int):
-    """Deletes a signal definition."""
-    signal = db_session.query(Signal).filter(Signal.id == signal_id).one()
-    db_session.delete(signal)
-    db_session.commit()
-    return signal_id
-
-
 def is_valid_uuid(val):
     try:
         uuid.UUID(str(val), version=4)
diff --git a/src/dispatch/signal/views.py b/src/dispatch/signal/views.py
index e8dab18aabe7..74202f39e4a8 100644
--- a/src/dispatch/signal/views.py
+++ b/src/dispatch/signal/views.py
@@ -36,7 +36,6 @@
     create,
     create_signal_engagement,
     create_signal_filter,
-    delete,
     delete_signal_filter,
     get,
     get_by_primary_or_external_id,
@@ -330,19 +329,3 @@ def update_signal(
         ) from None
 
     return signal
-
-
-@router.delete(
-    "/{signal_id}",
-    response_model=None,
-    dependencies=[Depends(PermissionsDependency([SensitiveProjectActionPermission]))],
-)
-def delete_signal(db_session: DbSession, signal_id: Union[str, PrimaryKey]):
-    """Deletes a signal."""
-    signal = get_by_primary_or_external_id(db_session=db_session, signal_id=signal_id)
-    if not signal:
-        raise HTTPException(
-            status_code=status.HTTP_404_NOT_FOUND,
-            detail=[{"msg": "A signal with this id does not exist."}],
-        )
-    delete(db_session=db_session, signal_id=signal.id)
diff --git a/src/dispatch/static/dispatch/src/signal/DeleteDialog.vue b/src/dispatch/static/dispatch/src/signal/DeleteDialog.vue
deleted file mode 100644
index 7036ee81151d..000000000000
--- a/src/dispatch/static/dispatch/src/signal/DeleteDialog.vue
+++ /dev/null
@@ -1,35 +0,0 @@
-<template>
-  <v-dialog v-model="showRemove" persistent max-width="800px">
-    <v-card>
-      <v-card-title>
-        <span class="text-h5">Delete Signal Definition?</span>
-      </v-card-title>
-      <v-card-text>
-        <v-container> Are you sure you would like to delete this Signal Definition? </v-container>
-      </v-card-text>
-      <v-card-actions>
-        <v-spacer />
-        <v-btn color="blue en-1" variant="text" @click="closeRemove()"> Cancel </v-btn>
-        <v-btn color="red en-1" variant="text" @click="remove()"> Delete </v-btn>
-      </v-card-actions>
-    </v-card>
-  </v-dialog>
-</template>
-
-<script>
-import { mapActions } from "vuex"
-import { mapFields } from "vuex-map-fields"
-export default {
-  name: "SignalDefinitionDeleteDialog",
-  data() {
-    return {}
-  },
-  computed: {
-    ...mapFields("signal", ["dialogs.showRemove"]),
-  },
-
-  methods: {
-    ...mapActions("signal", ["remove", "closeRemove"]),
-  },
-}
-</script>
diff --git a/src/dispatch/static/dispatch/src/signal/Table.vue b/src/dispatch/static/dispatch/src/signal/Table.vue
index 7b7a5fb1116f..0a438ba65f49 100644
--- a/src/dispatch/static/dispatch/src/signal/Table.vue
+++ b/src/dispatch/static/dispatch/src/signal/Table.vue
@@ -1,7 +1,6 @@
 <template>
   <v-container fluid>
     <new-edit-dialog />
-    <delete-dialog />
     <v-row no-gutters>
       <v-col>
         <v-alert closable icon="mdi-school" prominent text type="info">
@@ -88,9 +87,6 @@
                   <v-list-item @click="createEditShow(item)">
                     <v-list-item-title>View / Edit</v-list-item-title>
                   </v-list-item>
-                  <v-list-item @click="removeShow(item)">
-                    <v-list-item-title>Delete</v-list-item-title>
-                  </v-list-item>
                 </v-list>
               </v-menu>
             </template>
@@ -104,12 +100,12 @@
 <script>
 import { mapFields } from "vuex-map-fields"
 import { mapActions } from "vuex"
+
 import NewEditDialog from "@/signal/NewEditDialog.vue"
-import DeleteDialog from "@/signal/DeleteDialog.vue"
 
 export default {
   name: "SignalTable",
-  components: { NewEditDialog, DeleteDialog },
+  components: { NewEditDialog },
   props: {
     name: {
       type: String,
diff --git a/tests/signal/test_signal_service.py b/tests/signal/test_signal_service.py
index b1e301d42d07..820b90cc86a4 100644
--- a/tests/signal/test_signal_service.py
+++ b/tests/signal/test_signal_service.py
@@ -44,7 +44,7 @@ def test_update(session, project, signal):
 
 
 def test_update__add_filter(session, signal, signal_filter):
-    from dispatch.signal.models import SignalUpdate, SignalFilterRead
+    from dispatch.signal.models import SignalFilterRead, SignalUpdate
     from dispatch.signal.service import update
 
     signal_filter.project = signal.project
@@ -91,21 +91,15 @@ def test_update__delete_filter(session, signal, signal_filter):
     assert len(signal.filters) == 0
 
 
-def test_delete(session, signal):
-    from dispatch.signal.service import delete, get
-
-    delete(db_session=session, signal_id=signal.id)
-    assert not get(db_session=session, signal_id=signal.id)
-
-
 def test_filter_actions_default_deduplicate(session, signal, project):
-    from dispatch.signal.models import SignalInstance, SignalFilterAction
-    from dispatch.signal.service import filter_signal
-    from dispatch.entity_type.models import EntityType
+    from datetime import datetime, timedelta
+
+    from dispatch.case.models import Case
     from dispatch.entity.models import Entity
+    from dispatch.entity_type.models import EntityType
     from dispatch.enums import Visibility
-    from dispatch.case.models import Case
-    from datetime import datetime, timedelta
+    from dispatch.signal.models import SignalFilterAction, SignalInstance
+    from dispatch.signal.service import filter_signal
 
     entity_type = EntityType(
         name="default_dedupe",
@@ -163,14 +157,14 @@ def test_filter_actions_default_deduplicate(session, signal, project):
 
 
 def test_filter_actions_deduplicate_different_entities(session, signal, project):
+    from dispatch.entity.models import Entity
+    from dispatch.entity_type.models import EntityType
     from dispatch.signal.models import (
         SignalFilter,
-        SignalInstance,
         SignalFilterAction,
+        SignalInstance,
     )
     from dispatch.signal.service import filter_signal
-    from dispatch.entity_type.models import EntityType
-    from dispatch.entity.models import Entity
 
     entity_type_0 = EntityType(
         name="dedupe2-0",
@@ -216,14 +210,14 @@ def test_filter_actions_deduplicate_different_entities(session, signal, project)
 
 
 def test_filter_actions_deduplicate_different_entities_types(session, signal, project):
+    from dispatch.entity.models import Entity
+    from dispatch.entity_type.models import EntityType
     from dispatch.signal.models import (
         SignalFilter,
-        SignalInstance,
         SignalFilterAction,
+        SignalInstance,
     )
     from dispatch.signal.service import filter_signal
-    from dispatch.entity_type.models import EntityType
-    from dispatch.entity.models import Entity
 
     entity_type_0 = EntityType(
         name="dedupe0-0",
@@ -274,14 +268,14 @@ def test_filter_actions_deduplicate_different_entities_types(session, signal, pr
 
 
 def test_filter_actions_deduplicate(session, signal, project):
+    from dispatch.entity.models import Entity
+    from dispatch.entity_type.models import EntityType
     from dispatch.signal.models import (
         SignalFilter,
-        SignalInstance,
         SignalFilterAction,
+        SignalInstance,
     )
     from dispatch.signal.service import filter_signal
-    from dispatch.entity_type.models import EntityType
-    from dispatch.entity.models import Entity
 
     entity_type = EntityType(
         name="dedupe1",
@@ -325,14 +319,15 @@ def test_filter_actions_deduplicate(session, signal, project):
 
 def test_filter_action_with_dedupe_and_snooze(session, signal, project):
     from datetime import datetime, timedelta, timezone
+
+    from dispatch.entity.models import Entity
+    from dispatch.entity_type.models import EntityType
     from dispatch.signal.models import (
         SignalFilter,
-        SignalInstance,
         SignalFilterAction,
+        SignalInstance,
     )
     from dispatch.signal.service import filter_signal
-    from dispatch.entity_type.models import EntityType
-    from dispatch.entity.models import Entity
 
     entity_type = EntityType(
         name="dedupe1+snooze",
@@ -386,13 +381,14 @@ def test_filter_action_with_dedupe_and_snooze(session, signal, project):
 
 def test_filter_actions_snooze(session, entity, signal, project):
     from datetime import datetime, timedelta, timezone
+
+    from dispatch.entity_type.models import EntityType
     from dispatch.signal.models import (
         SignalFilter,
-        SignalInstance,
         SignalFilterAction,
+        SignalInstance,
     )
     from dispatch.signal.service import filter_signal
-    from dispatch.entity_type.models import EntityType
 
     entity_type = EntityType(
         name="test",
@@ -430,13 +426,14 @@ def test_filter_actions_snooze(session, entity, signal, project):
 
 def test_filter_actions_snooze_expired(session, entity, signal, project):
     from datetime import datetime, timedelta, timezone
+
+    from dispatch.entity_type.models import EntityType
     from dispatch.signal.models import (
         SignalFilter,
-        SignalInstance,
         SignalFilterAction,
+        SignalInstance,
     )
     from dispatch.signal.service import filter_signal
-    from dispatch.entity_type.models import EntityType
 
     entity_type = EntityType(
         name="test",