From 54a4d313762d56a1a576c6028d43756bf0fb6eea Mon Sep 17 00:00:00 2001 From: Eduardo Ramirez Date: Fri, 15 Dec 2023 21:43:51 -0800 Subject: [PATCH] fix: removes memory leak (ref 'this') from HollowConsumerBuilder (#653) --- .../java/com/netflix/hollow/api/consumer/HollowConsumer.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hollow/src/main/java/com/netflix/hollow/api/consumer/HollowConsumer.java b/hollow/src/main/java/com/netflix/hollow/api/consumer/HollowConsumer.java index 3b560aa4b2..327e4902c1 100644 --- a/hollow/src/main/java/com/netflix/hollow/api/consumer/HollowConsumer.java +++ b/hollow/src/main/java/com/netflix/hollow/api/consumer/HollowConsumer.java @@ -1365,7 +1365,8 @@ protected void checkArguments() { } if (refreshExecutor == null) { - refreshExecutor = newSingleThreadExecutor(r -> daemonThread(r, getClass(), "refresh")); + final Class clazz = getClass(); // to avoid capturing 'this' in lambda + refreshExecutor = newSingleThreadExecutor(r -> daemonThread(r, clazz, "refresh")); } if (!memoryMode.consumerSupported()) {