[Geode] Exclude Log4j dependency getting shipped with ndbench-web module

[pulkit-chandra]

Hi All,

I have discussed this on the gitter chat. Basically right now Apache Geode has a hard dependency on log4j provider. Which means if any other module brings in their own logging provider jar file in the web module the Apache Geode gets broken.

Hi all, Geode plugin for NDBench is broken on Master due to latest version of NdBench pushing Slf4j as a provider for logging. Since Geode needs log4j as the provider we need to use the bridge slf4j to log4j which is not compatible with the parent NdBench dependency. I have a branch on my fork which solves that but requires that we move the dependency on logging provide a responsibility of connectors. I have made changes for all the plugins, but just FYI for the group to keep the dependency at the parent level minimum. Please let me know if their are concerns. I will also create a Bug for this.

Ioannis Papapanagiotou
@ipapapa
Apr 12 2018 11:08
@pulkitpivotal the Slf4j in ndbench-web was included in the initial commit when we OSSed it.
https://github.com/Netflix/ndbench/blame/e59776693f000e11c185bc401e6e90192dd134b2/ndbench-web/build.gradle
Can you point me to the latest updated that has broken your work?

Pulkit Chandra
@pulkitpivotal
Apr 17 2018 08:48

@ipapapa I am looking into which commit broke us. I also think ndbench-web pulls in dependencies of all the plugins which can cause issues as different plugins will have different implementation of logging. e.g. if you see here

dependencies {
    compile project(':ndbench-core')
    compile project(':ndbench-api')
    compile (project(':ndbench-cass-plugins')) {
        exclude group: 'ch.qos.logback'
    }
    compile project(':ndbench-dyno-plugins')
    compile project(':ndbench-sample-plugins')
    compile project(':ndbench-es-plugins')
    compile project(':ndbench-geode-plugins')
    compile project(':ndbench-janusgraph-plugins')
    compile 'com.google.inject.extensions:guice-servlet:4.0'
    compile 'com.google.inject:guice:4.0'
    compile group: 'com.owlike', name: 'genson', version: '1.4'

}

You need to make a explicit decision to exclude your compile time dependencies in this project otherwise they will be pulled and that is the root of the issue. Once I have more information on this I will share here.
Ioannis Papapanagiotou
@ipapapa
Apr 23 2018 15:56
@pulkitpivotal thanks for taking a look.
Please these information in the issue so that we can track it.
I am working on something else right now and I do not want to forget this.
Pulkit Chandra
@pulkitpivotal
Jun 19 2018 13:48
@ipapapa Between 15397bc4062bc0fd221c5a3887aa9bcc9d54e018 and 587655c2a1ffee54b75a4f129c30cda3c45a5131 Geode plugin was broken.
FYI, for future, we have code which is pulling down latest version of dependencies in the project, without locking versions. This means when I am checking out code for a sha, I have to keep in mind the dependencies would be latest with old code. This causes failure all over the place. I think we should lock all the dependencies with proper versions. Just my 2 cent :)
Ioannis Papapanagiotou
@ipapapa
Jun 19 2018 13:53
@pulkitpivotal we do lock dependencies internally but we have not done it externally. If you wish to file a PR for that please go ahead.

I have gone through to exclude all the providers from the web module on my local branch. But I wanted to check with the community if that could potentially affect other plugins before I raise a PR.

I will also make the changes to lock the versions with another issue.

Thanks !